Skip to content

Commit

Permalink
ignore more false positive clippy lints
Browse files Browse the repository at this point in the history
  • Loading branch information
connorskees committed Jul 9, 2023
1 parent a3e9233 commit 69e0938
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 30 deletions.
2 changes: 1 addition & 1 deletion crates/compiler/src/ast/args.rs
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ impl ArgumentResult {
let len = self.len();
if len > max {
let mut err = String::with_capacity(50);
#[allow(clippy::format_push_string)]
#[allow(unknown_lints, clippy::format_push_string)]
err.push_str(&format!("Only {max} argument", max = max));
if max != 1 {
err.push('s');
Expand Down
5 changes: 5 additions & 0 deletions crates/compiler/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,11 @@ grass input.scss
clippy::cast_precision_loss,
clippy::float_cmp,
// todo: unignore once we bump MSRV
clippy::format_push_string,
clippy::unnecessary_unwrap,
clippy::needless_late_init,
unknown_lints,
)]

Expand Down
7 changes: 3 additions & 4 deletions crates/compiler/src/parse/stylesheet.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1196,10 +1196,9 @@ pub(crate) trait StylesheetParser<'a>: BaseParser<'a> + Sized {

let right = self.supports_condition_in_parens()?;
operation = Some(AstSupportsCondition::Operation {
left: Box::new(
operation
.unwrap_or(AstSupportsCondition::Interpolation(expression.clone().node)),
),
left: Box::new(operation.unwrap_or_else(|| {
AstSupportsCondition::Interpolation(expression.clone().node)
})),
operator: operator.clone(),
right: Box::new(right),
});
Expand Down
35 changes: 10 additions & 25 deletions crates/lib/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -36,46 +36,31 @@ grass input.scss
#![deny(missing_debug_implementations)]
#![allow(
clippy::use_self,
clippy::missing_docs_in_private_items,
clippy::unreachable,
clippy::module_name_repetitions,
// filter isn't fallible
clippy::manual_filter_map,
clippy::new_ret_no_self,
renamed_and_removed_lints,
clippy::unknown_clippy_lints,
clippy::single_match,
clippy::unimplemented,
clippy::option_if_let_else,
clippy::branches_sharing_code,
clippy::derive_partial_eq_without_eq,
// temporarily allowed while under heavy development.
// eventually these allows should be refactored away
// to no longer be necessary
clippy::too_many_lines,
clippy::cast_possible_truncation,
clippy::new_without_default,
clippy::single_match_else,
clippy::redundant_pub_crate,
// the api is changing too often to allot this
clippy::missing_errors_doc,
clippy::missing_const_for_fn,
clippy::multiple_crate_versions,
clippy::wrong_self_convention,
clippy::items_after_statements,
// this is only available on nightly
clippy::comparison_chain,
// these features are only available on nightly
clippy::unnested_or_patterns,
clippy::uninlined_format_args,
// todo:
// todo: these should be enabled
clippy::cast_sign_loss,
clippy::cast_lossless,
clippy::cast_precision_loss,
clippy::float_cmp,
clippy::wildcard_imports,
clippy::comparison_chain,
clippy::bool_to_int_with_if,
// todo: unignore once we bump MSRV
clippy::format_push_string,
clippy::unnecessary_unwrap,
clippy::needless_late_init,
unknown_lints,
)]
Expand Down

0 comments on commit 69e0938

Please sign in to comment.