Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set a default page size in the GraphQL API #2721

Merged
merged 4 commits into from Jun 2, 2022
Merged

Set a default page size in the GraphQL API #2721

merged 4 commits into from Jun 2, 2022

Commits on Jun 1, 2022

  1. Regenerate sorbet types.

    @connorshea
    connorshea committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    3f281c8 View commit details
    Browse the repository at this point in the history

  2. Add default_page_size to GraphQL schema and set max to 100. 

    This way, nothing changes about the default page size, but API users can
request more records per request if necessary.
    @connorshea
    connorshea committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    26dcfd3 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2022

  1. Fix up the page_size and total_count methods. 

    This corrects a mistake I made a while ago when implementing page_size.
    @connorshea
    connorshea committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    507060e View commit details
    Browse the repository at this point in the history

  2. Appease rubocop.

    @connorshea
    connorshea committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    f8cc636 View commit details
    Browse the repository at this point in the history