Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Sorbet #1794

Merged
merged 3 commits into from
Jan 18, 2021
Merged

Update Sorbet #1794

merged 3 commits into from
Jan 18, 2021

Conversation

connorshea
Copy link
Owner

@connorshea connorshea commented Jan 18, 2021 •
edited

And regenerate types, and fix an issue with our custom sorbet-rails plugin.

This doesn't regenerate the gem RBIs due to this issue with Tapioca: Shopify/tapioca#208

@connorshea connorshea added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code technical debt Missing tests, dependencies that need updating, code that needs to be refactored, etc. labels Jan 18, 2021
@connorshea connorshea merged commit cb369f8 into master Jan 18, 2021
@connorshea connorshea deleted the sorbet-update-jan182021 branch January 18, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code technical debt Missing tests, dependencies that need updating, code that needs to be refactored, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@connorshea