Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Update node label #919

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

MINOR: Update node label #919

wants to merge 2 commits into from

Conversation

jolshan
Copy link
Member

@jolshan jolshan commented Jul 25, 2023

After some discussion on why builds were timing out for a month, it seems that this change fe6a827 was incompatible with the jdk image currently used.

Updating the image so builds do not time out.

@jolshan jolshan requested review from a team as code owners July 25, 2023 20:09
@ijuma
Copy link
Member

ijuma commented Jul 25, 2023

I think the explanation is that we're triggering a JDK bug. That's worrisome though and we should probably file a JIRA upstream with the JDK version so the contributor can figure out what to do (either have a "known issues" note or fine a workaround).

@jolshan
Copy link
Member Author

jolshan commented Jul 25, 2023

That's a fair point. I'm struggling to figure out the exact bug but it seems that it was hit on the new java 8 version I tried as well. Not sure why AK was able to handle it fine.

@jolshan
Copy link
Member Author

jolshan commented Aug 2, 2023

I found that reverting the test here allowed the build to complete. 185d187

I think we still need to update the node label, so I can leave this open, but we don't need to file an issue with the jdk (for now)

@cla-assistant
Copy link

cla-assistant bot commented Oct 12, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants