Fix some small bugs including incorrect argument parsing and a race c… #133

benstopford · 2018-07-18T13:55:24Z

…ondition

mjsax

@benstopford Seems this PR slipped through. Sorry for that.

mjsax · 2019-01-20T17:53:41Z

src/test/java/io/confluent/examples/streams/microservices/EndToEndTest.java

@@ -163,7 +163,7 @@ public void startEverythingElse() throws Exception {
    services.add(new OrderDetailsService());
    services.add(new ValidationsAggregatorService());

-    tailAllTopicsToConsole(CLUSTER.bootstrapServers());
+//    tailAllTopicsToConsole(CLUSTER.bootstrapServers());


mjsax · 2019-01-20T17:54:06Z

src/main/java/io/confluent/examples/streams/microservices/util/MicroserviceUtils.java

@@ -40,8 +40,8 @@ public static String parseArgsAndConfigure(String[] args) {
          "[<bootstrap.servers> (optional, default: " + DEFAULT_BOOTSTRAP_SERVERS + ")] " +
          "[<schema.registry.url> (optional, default: " + DEFAULT_SCHEMA_REGISTRY_URL + ")] ");
    }
-    final String bootstrapServers = args.length > 1 ? args[1] : "localhost:9092";
-    final String schemaRegistryUrl = args.length > 2 ? args[2] : "http://localhost:8081";
+    final String bootstrapServers = args.length >= 1 ? args[0] : "localhost:9092";


nit: args.length > 0 (also next line)

mjsax · 2019-01-20T17:54:13Z

src/test/java/io/confluent/examples/streams/microservices/ValidationsAggregatorServiceTest.java

@@ -36,7 +36,7 @@ public static void startKafkaCluster() {
    CLUSTER.createTopic(Topics.ORDERS.name());
    CLUSTER.createTopic(Topics.ORDER_VALIDATIONS.name());
    Schemas.configureSerdesWithSchemaRegistryUrl(CLUSTER.schemaRegistryUrl());
-    MicroserviceTestUtils.tailAllTopicsToConsole(CLUSTER.bootstrapServers());
+//    MicroserviceTestUtils.tailAllTopicsToConsole(CLUSTER.bootstrapServers());


mjsax · 2019-01-20T17:56:15Z

I guess, the PR should be targeted against 4.1.0-post instead?

Fix some small bugs including incorrect argument parsing and a race c…

f715806

…ondition

mjsax reviewed Jan 20, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix some small bugs including incorrect argument parsing and a race c… #133

Fix some small bugs including incorrect argument parsing and a race c… #133

benstopford commented Jul 18, 2018

mjsax left a comment

mjsax Jan 20, 2019

mjsax Jan 20, 2019

mjsax Jan 20, 2019

mjsax commented Jan 20, 2019

Fix some small bugs including incorrect argument parsing and a race c… #133

Are you sure you want to change the base?

Fix some small bugs including incorrect argument parsing and a race c… #133

Conversation

benstopford commented Jul 18, 2018

mjsax left a comment

Choose a reason for hiding this comment

mjsax Jan 20, 2019

Choose a reason for hiding this comment

mjsax Jan 20, 2019

Choose a reason for hiding this comment

mjsax Jan 20, 2019

Choose a reason for hiding this comment

mjsax commented Jan 20, 2019