#538 - LOG_DIR not set causing FileNotFoundException #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@confluentinc It looks like @MarkC0x just signed our Contributor License Agreement. 👍 Always at your service, clabot |
rigelbm
reviewed
Jun 3, 2020
| @@ -39,6 +39,11 @@ if [ "x$KAFKAREST_LOG4J_OPTS" = "x" ]; then | |||
| fi | |||
| fi | |||
|
|
|||
| # Log directory to use | |||
| if [ "x$LOG_DIR" = "x" ]; then | |||
There was a problem hiding this comment.
[[ -z "${LOG_DIR+x}" ]] && LOG_DIR="$base_dir/logs"
There was a problem hiding this comment.
BTW, not sure if $base_dir/logs is a better default log folder than, for example, /var/log/kafka-rest. AK uses /var/log/kafka by default, I think.
There was a problem hiding this comment.
Thanks for reviewing @rigelbm -- I used the same $base_dir/logs default folder code present in both AK and CP kafka-run-class files, so that things remained consistent. I can change the logic to your modified version though if you prefer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that this same
LOG_DIRnot set causingFileNotFoundExceptionbehavior was still happening in the latest 5.5.x version of Rest Proxy.Created a simple PR to correctly set the base log directory for the logs.