Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove choosePort and rely on dynamic, OS-allocated ports during tests #414

Open
wants to merge 1 commit into
base: 3.0.x
Choose a base branch
from
Open

Remove choosePort and rely on dynamic, OS-allocated ports during tests #414

wants to merge 1 commit into from

Conversation

ewencp
Copy link
Contributor

@ewencp ewencp commented Mar 12, 2018

No description provided.

@ewencp ewencp requested a review from a team March 12, 2018 03:51
@ewencp ewencp mentioned this pull request Mar 12, 2018
Open
@ewencp
Copy link
Contributor Author

ewencp commented Mar 12, 2018

Works in conjunction with confluentinc/rest-utils#90 and avoids Address already in use errors during tests due to choosePort not being a reliable way to select a random available port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mageshn mageshn mageshn approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ewencp @mageshn