Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Stats.Bytes() #999

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Stats.Bytes() #999

wants to merge 1 commit into from

Conversation

jdemeyer
Copy link
Contributor

Given that Go uses []byte mostly to represent JSON data, it makes a lot of sense to add a Stats.Bytes() call returning a []byte instead of a string.

Perhaps it might even make sense to store the data as []byte internally in the Stats struct, but that's then an implementation detail which can be changed later.

@cla-assistant
Copy link

cla-assistant bot commented Aug 4, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jdemeyer