New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KIP-848] Run integration tests with both the "classic" and "consumer" consumer groups #1185
Conversation
"consumer" consumer groups
9f8e65c
to
d194ad1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay except one comment
kafka/testresources/kraft/Dockerfile
Outdated
RUN apt install -y git curl | ||
RUN apt install -y openjdk-17-jdk | ||
|
||
RUN git clone https://github.com/apache/kafka.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should checkout to a branch or a tag after this for making sure tests don't break at some random point in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment there's no tag to checkout as 3.7.0 needed some fixes I could leave current commit in trunk and we update it when needed before 3.8.0
is still not available
@milindl sent a commit, please check again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR itself looks OK barring the KRaft+classic failures
Yeah, we need to add a test run with classic + kraft. We shouldn't have a flag to check if we have ZK or KRaft so later we can have checks based on AK version: one test with last AK that can run with ZK (3.8), another one with AK 4.0+ using KRaft and "classic" and a third one with 4.0+and "consumer" and we assume KRaft for 4.0 ones |
No description provided.