Use unsafe.SliceData() #1178
Open
Use unsafe.SliceData() #1178
+10
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdemeyer
force-pushed
the
unsafe-slicedata
branch
from
148d893
to
7b31f25
Compare
|
Great stuff, thanks for this PR. I only skimmed the PR yet, but I do believe it makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we require Go 1.21 now, we can use
unsafe.SliceDatawhich simplifies quite a bit of code involving passing slices to C. I focused on the most important places in the code where such a conversion was done. If this PR is approved, I can do the other places also.While I was at it, I also replaced
UnixNano()/1000000byUnixMilli()in code I was editing anyway.