Get effective compatibility level of subject #1150
Conversation
|
|
|
|
| @@ -212,7 +212,7 @@ type Client interface { | |||
| GetAllSubjects() ([]string, error) | |||
| DeleteSubject(subject string, permanent bool) ([]int, error) | |||
| DeleteSubjectVersion(subject string, version int, permanent bool) (deletes int, err error) | |||
| GetCompatibility(subject string) (compatibility Compatibility, err error) | |||
| GetCompatibility(subject string, defaultToGlobal bool) (compatibility Compatibility, err error) | |||
There was a problem hiding this comment.
As discussed, this might break existing code because the function signature changes.
| var result compatibilityLevel | ||
| err = c.restService.handleRequest(newRequest("GET", subjectConfig, nil, url.PathEscape(subject)), &result) | ||
| err = c.restService.handleRequest(newRequest("GET", subjectConfigDefaultToGlobal, nil, |
There was a problem hiding this comment.
Here, this would change requests for the existing code in a way that ?defaultToGlobal=false is always appended. This should not cause issues (e.g. older versions of schema registry that might not know this parameter?).
|
Thanks @shalinibani01 , I believe this PR is subsumed by #1149 |
Thanks! Since the changes that are present in this PR are already present in yours, I am closing this one. |
This PR extends
GETrequest to get effective compatibility level of a given subject.The orginal issue is described here #1090.