Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md for v2.3.0 #1087

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md for v2.3.0 #1087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ for use with [Confluent Cloud](https://www.confluent.io/confluent-cloud/).
Getting Started
===============

Supports Go 1.17+ and librdkafka 2.2.0+.
Supports Go 1.17+ and librdkafka 2.3.0+.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a maintainer but was just looking at a few changes. I think it is possible this should say "Supports Go 1.19+", based on this line: https://github.com/confluentinc/confluent-kafka-go/blob/master/kafka/README.md?plain=1#L5 ; It would be nice if a maintainer could confirm while we are fixing the documentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit confusing - we do intend to support Go1.17 for end users as long as we can (hence the root directory README.md). I'll add something to the CI to check go 1.17 builds in release tags as well.

But it's unreasonable to expect a developer to be using Go1.17 which doesn't have official support. So we ask the developers working on to use the oldest officially supported version as in the kafka/README.md, which was last updated when go1.19 was still supported.

It should be 1.20 now. I'll try to update that.


Using Go Modules
----------------
Expand Down