Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bcprov-jdk15on #605

Open
wants to merge 2 commits into
base: 6.2.x
Choose a base branch
from
Open

Conversation

xjin-Confluent
Copy link
Member

No description provided.

Copy link

cla-assistant bot commented May 8, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@janjwerner-confluent janjwerner-confluent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
we should also remove the ${bouncycastle.version} definition in line 101

@xjin-Confluent
Copy link
Member Author

@janjwerner-confluent Nice catch and it is fixed.

@xjin-Confluent xjin-Confluent requested a review from a team May 14, 2024 00:01
Copy link
Member

@janjwerner-confluent janjwerner-confluent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
We need to monitor for possible failures downstream.
Currently I'm trying to navigate
https://github.com/confluentinc/ce-kafka-rest/pull/694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants