Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EasyMock version to be compatible with Jdk 17+ #575

Open
wants to merge 1 commit into
base: 7.3.0-post
Choose a base branch
from

Conversation

trnguyencflt
Copy link
Member

@trnguyencflt trnguyencflt commented Dec 12, 2023

The version of easymock in 7.3.x branch is 5.2.0 while all 7.3.x-post branches are 4.3.

EasyMock version 4.3 isn't compatible with Jdk 17 (used in Semaphore) so upgrading it. As far as compatibility issue concern, as EasyMock 5.2.0 is used in branch 7.3.x already, it should not be a problem.

@trnguyencflt trnguyencflt requested a review from a team as a code owner December 12, 2023 10:48
Copy link

cla-assistant bot commented Dec 12, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

cla-assistant bot commented Dec 12, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@janjwerner-confluent janjwerner-confluent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, started a rebuild as the pr merge test failed downloading kafka artifacts. let's see the outcome of the downstream validation.

@trnguyencflt
Copy link
Member Author

trnguyencflt commented Dec 13, 2023

lgtm, started a rebuild as the pr merge test failed downloading kafka artifacts. let's see the outcome of the downstream validation.

@janjwerner-confluent thanks, the build on Jenkins still fail with this error for which I don't really know how to fix 😢

13:03:25  [ERROR] Failed to execute goal io.confluent:resolver-maven-plugin:0.5.0:resolve-kafka-range (default-cli) on project common-parent: MojoExecutionException: Could not find any ce-kafka artifacts. -> [Help 1]

Is that still ok to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants