Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cobra to return non-zero exit codes upon non-runnable subcommands. #281

Merged
merged 2 commits into from Sep 9, 2019
Merged

Update cobra to return non-zero exit codes upon non-runnable subcommands. #281

merged 2 commits into from Sep 9, 2019

Conversation

mpokryva
Copy link

@mpokryva mpokryva commented Sep 6, 2019 •
edited

What

Update cobra to return non-zero exit codes upon non-runnable subcommands.

References

spf13/cobra#922

Test&Review

Manually tested.

@mpokryva mpokryva requested a review from a team as a code owner September 6, 2019 22:53
@mpokryva mpokryva requested a review from DABH September 6, 2019 22:55
@codecov
Copy link

codecov bot commented Sep 6, 2019

Codecov Report

Merging #281 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #281   +/-   ##
=======================================
  Coverage   41.02%   41.02%           
=======================================
  Files          62       62           
  Lines        4739     4739           
=======================================
  Hits         1944     1944           
  Misses       2550     2550           
  Partials      245      245

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afde29c...533cebc. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Sep 6, 2019 •
edited

Codecov Report

Merging #281 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #281   +/-   ##
=======================================
  Coverage   41.02%   41.02%           
=======================================
  Files          62       62           
  Lines        4739     4739           
=======================================
  Hits         1944     1944           
  Misses       2550     2550           
  Partials      245      245

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afde29c...533cebc. Read the comment docs.

DABH
DABH approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@DABH DABH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpokryva mpokryva merged commit 6235657 into master Sep 9, 2019
@mpokryva mpokryva deleted the CLI-250 branch September 9, 2019 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DABH DABH DABH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mpokryva @DABH