Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help output and integration test naming changes #1860

Closed
wants to merge 17 commits into from
Closed

Help output and integration test naming changes #1860

wants to merge 17 commits into from

Conversation

sgagniere
Copy link
Member

Release Notes

Breaking Changes

  • PLACEHOLDER

New Features

  • PLACEHOLDER

Bug Fixes

  • PLACEHOLDER

Checklist

  1. [CRUCIAL] Is the change for features that are already live in prod?
    • yes: ok

What

Followup to comments from autocompletion PR. Two things here:

  • Change argument labels on the Use lines to match the field label (as shown in describe/list). The only exception is ksql cluster configure-acls, where topic arguments aren't shown in any output so I just renamed it to topic-name for clarity.
  • Rename test suite functions to have the form Test{Command}_, e.g. TestEnvironment_Describe. I also changed command acronyms to be lowercase after the first letter.

References

Followup to the comments here: #1847

Test & Review

Ran tests

Open Questions / Follow-ups

@sgagniere sgagniere requested a review from a team as a code owner April 14, 2023 19:00
brianstrauch
brianstrauch requested changes Apr 14, 2023
View reviewed changes
internal/cmd/connect/command_plugin_describe.go Outdated Show resolved Hide resolved
internal/cmd/kafka/command_broker_describe.go Outdated Show resolved Hide resolved
internal/cmd/kafka/command_broker_delete.go Outdated Show resolved Hide resolved
test/asyncapi_test.go Outdated Show resolved Hide resolved
test/asyncapi_test.go Outdated Show resolved Hide resolved
sgagniere and others added 2 commits April 14, 2023 12:33
@sgagniere @brianstrauch
Update internal/cmd/kafka/command_broker_describe.go
5f1d5a4 
Co-authored-by: Brian Strauch <bstrauch@confluent.io>
@sgagniere @brianstrauch
Update test/asyncapi_test.go
42bee8e 
Co-authored-by: Brian Strauch <bstrauch@confluent.io>
sgagniere
sgagniere commented Apr 14, 2023
View reviewed changes
test/asyncapi_test.go Outdated Show resolved Hide resolved
sgagniere and others added 3 commits April 14, 2023 12:38
sgagniere
sgagniere commented Apr 14, 2023
View reviewed changes
test/price_test.go Outdated Show resolved Hide resolved
@sgagniere sgagniere closed this Jul 14, 2023
@brianstrauch brianstrauch deleted the small-cleanup branch January 11, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianstrauch brianstrauch brianstrauch requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgagniere @brianstrauch