Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI-2332] Add --availability and --type to kafka cluster update #1715

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

brianstrauch
Copy link
Member

@brianstrauch brianstrauch commented Feb 15, 2023

Checklist

  1. [CRUCIAL] Is the change for features that are already live in prod?
    • yes: ok

What

  • Update a dedicated cluster to multi-zone with kafka update --availability multi-zone
  • Update a basic/standard cluster to multi-zone with kafka update --availability multi-zone --type dedicated

References

https://confluentinc.atlassian.net/wiki/spaces/KPLATFORM/pages/2928020393/Engineering+One+Pager+Standard+Cluster+Single-Zone+to+Multi-Zone+Migration#CLI-Workflow

Test & Review

Untested, since backend is still a WIP. Planning to write integration tests and system tests.

@brianstrauch brianstrauch requested a review from a team as a code owner February 15, 2023 01:07
@brianstrauch brianstrauch marked this pull request as draft February 15, 2023 01:07
Copy link
Member

@tmodi11 tmodi11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianstrauch Thanks for all your work on this! Did a first pass and left some comments.

internal/cmd/kafka/command_cluster_update.go Show resolved Hide resolved
internal/cmd/kafka/command_cluster_update.go Show resolved Hide resolved
internal/cmd/kafka/command_cluster_update.go Show resolved Hide resolved
internal/cmd/kafka/command_cluster_update.go Show resolved Hide resolved
internal/cmd/kafka/command_cluster_update.go Show resolved Hide resolved
internal/cmd/kafka/command_cluster_update.go Show resolved Hide resolved
internal/cmd/kafka/command_cluster_update.go Show resolved Hide resolved
internal/cmd/kafka/command_cluster_update.go Outdated Show resolved Hide resolved
internal/cmd/kafka/command_cluster_update.go Show resolved Hide resolved
internal/cmd/kafka/utils.go Show resolved Hide resolved
@brianstrauch brianstrauch changed the title Add --availability and --type to kafka cluster update [CLI-2332] Add --availability and --type to kafka cluster update Jul 21, 2023
@cla-assistant
Copy link

cla-assistant bot commented Aug 15, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants