Upgrade to telescope

[pyramation]

No description provided.

[pyramation]

@webmaster128 the only potential blocker I see is the eslint disable, do we need this?

telescope already has a ts lint disable mechanism, so we can add one for eslint if needed.

[webmaster128]

@webmaster128 the only potential blocker I see is the eslint disable, do we need this?

telescope already has a ts lint disable mechanism, so we can add one for eslint if needed.

For me this is nice to have. I don't really need it. However when people copy/paste generated files around it is convenient for them that the linting is disabled by default without them having to configure something in their project setup.

[pyramation]

order of these changed, but it doesn't change the behavior. This is due to the many nested sub types. Looks good in terms of structure.

[pyramation]

is this used?

[pyramation]

A few minor things, anything more than minor I don't think actually hits any codepaths.

[pyramation]

A few minor things, anything more than minor I don't think actually hits any codepaths.

[pyramation]

this comment seems to be the only one due to a newline that is stuck. I suggest we fix the proto for this one.

[webmaster128]

So, finnally got the chance to look into this. I found a few more things, but overall this is very cool.

[webmaster128]

This would break the client code using the fields. Why are _ used here? All other fields are in camelCase, so the _ feels a bit misplaced.

[pyramation]

• underscore casing found cosmology-tech/telescope#66

[pyramation]

@webmaster128 the protos look like this https://github.com/cosmos/ibc-go/blob/c8e2ebcf2eaa6b487ca52499063c7c3db4253398/proto/ibc/lightclients/tendermint/v1/tendermint.proto#L84-L85

message Misbehaviour {
  option (gogoproto.goproto_getters) = false;

  // ClientID is deprecated
  string client_id = 1 [deprecated = true, (gogoproto.moretags) = "yaml:\"client_id\""];
  Header header_1  = 2 [(gogoproto.customname) = "Header1", (gogoproto.moretags) = "yaml:\"header_1\""];
  Header header_2  = 3 [(gogoproto.customname) = "Header2", (gogoproto.moretags) = "yaml:\"header_2\""];
}

[pyramation]

One solution that seems that it may work (at least for this case) is to camelCase the gogoproto.customname to get the expected result. Other than that, removing the underscore I don't think is a default to the camelCase function that is used by protobuf.js

[pyramation]

specifically, the camelCase as defined in protobuf.js is this one (which does not remove the underscore)

var camelCaseRe = /_([a-z])/g;
const camelCase = function camelCase(str) {
    return str.substring(0, 1)
         + str.substring(1)
               .replace(camelCaseRe, function($0, $1) { return $1.toUpperCase(); });
}

So another approach could be to manually look for a pattern. We could use a pattern like /[a-zA-Z0-9]+_[0-9]+$/, we could remove the underscore?

• use pattern?
• camelCase gogoproto.customname
• something else?

[pyramation]

UPDATE: I decided to use the assumption that if there is an underscore with only a number after it, then the underscore should be removed. This is only in the case where it ends with numbers only, if there are any words we leave it alone.

To be honest, I'm not super confident this change would break client code. If it did, it would break amino, not proto, and I'm actually wondering if this new change will break the client code (for amino) as the original developer wrote the prop names with underscores, and from what I've discovered the original authored casing is what typically matters in amino.

[pyramation]

I will dig into the optional fields today to get your questions answered, but also fix it so they match the ts-proto output. Thanks for the useful info.

I think most should be solvable. I'll be tracking the issues here cosmology-tech/telescope#237

[pyramation]

kept comments here but to avoid confusion with older changes, I've superseded this PR with this one: #44