Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #208 - Do not move non-existing files #209

Merged
merged 5 commits into from Nov 11, 2022
Merged

Issue #208 - Do not move non-existing files #209

merged 5 commits into from Nov 11, 2022

Conversation

martin-g
Copy link
Contributor

This is a small improvement to not try to move .bashrc into .profile if
.bashrc does not even exists.

This is needed for non-ephemeral self-hosted Github Actions runners
where one VM could run multiple runners.

There is still a chance another GHA runner to move the file between the existsSync and io.mv calls.

@martin-g
Copy link
Contributor Author

There is still a chance another GHA runner to move the file between the existsSync and io.mv calls.

I don't see a solution for this problem except stop using the shell rc files completely.

Would it be possible to just issue conda activate XYZ when/where needed instead of adding bashExtraText to ~/.profile ?

@goanpeca
Copy link
Member

goanpeca commented Dec 29, 2021 •
edited

Thanks for working on this @martin-g

goanpeca
goanpeca approved these changes Dec 29, 2021
View reviewed changes
Copy link
Member

@goanpeca goanpeca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@martin-g martin-g mentioned this pull request Dec 30, 2021
Open
@goanpeca goanpeca changed the base branch from master to develop May 26, 2022 16:25
@goanpeca goanpeca added this to the v2.2.0 milestone May 26, 2022
martin-g and others added 2 commits May 31, 2022 15:42
@martin-g @goanpeca
Issue conda-incubator#208 - Do not move non-existing files
597256b 
This is a small improvement to not try to move .bashrc into .profile if
.bashrc does not even exists.

This is needed for non-ephemeral self-hosted Github Actions runners
where one VM could run multiple runners
@goanpeca
Fix format
0e0a829
@goanpeca goanpeca force-pushed the dont-move-file-that-dont-exist branch from f5bbd6a to 0e0a829 Compare May 31, 2022 20:44
@goanpeca goanpeca merged commit 5df0c47 into conda-incubator:develop Nov 11, 2022
@goanpeca
Copy link
Member

Sorry for the delays! And thanks again for your contribution 🚀

@martin-g martin-g deleted the dont-move-file-that-dont-exist branch November 15, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goanpeca goanpeca goanpeca approved these changes

Assignees

@bollwyvl bollwyvl

@jaimergp jaimergp

Labels
None yet
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@martin-g @goanpeca @bollwyvl @jaimergp