[wip] [5 of #107] add dynamic options #125
Merged
+276
−231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This encapsulates the state that does change, as highlighted in #124, in a single, relatively lenient object, and changes most function signatures to accept inputs, options or both.
On the next PR
One of the first "irregularities" is that
runInstaller
is allowed to calculate its ownoutputPath
, which requires access to mutable state. If we split up that behavior, we can get a lot of reuse, where it will be more straightforward to add additional "well-known" installer providers.The idea here is to break up the installer provisioning step even more. There should be a significant net negative line count in
setup.ts
, and encapsulate the logic more succinctly along with its effects.This is where we want to leave enough breathing room to handle micromamba #75 without actually building it right now.