Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pyyaml <6 #3

Merged
merged 4 commits into from
Jul 3, 2022
Merged

Conversation

mikemhenry
Copy link
Contributor

@mikemhenry mikemhenry commented Feb 24, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mikemhenry
Copy link
Contributor Author

@conda-forge-admin, please rerender

@mikemhenry
Copy link
Contributor Author

@jchodera assuming this builds fine, this will fix
#1
choderalab/yank#1264

I will do a more complete fix on the next yak release

@lilyminium
Copy link

Just checking in, it would be great to see this update in production! I keep forgetting to pin the yank version myself, and OpenFF Evaluator happily runs for 8 hours before failing here and deleting all intermediate data 😭

@jchodera
Copy link
Contributor

@mikemhenry Can you help get this out if it's ready?

Copy link
Contributor

@jchodera jchodera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Thanks!

@mikemhenry
Copy link
Contributor Author

@conda-forge-admin, please rerender

@mikemhenry
Copy link
Contributor Author

@jchodera @jaimergp could one of you merge this in (after CI passes, you should be able to add the auto merge label)? I had forgotten about it, but it is still needed. I've added myself to the maintainers list for future PRs.

Copy link
Contributor

@jchodera jchodera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mikemhenry, and apologies for the delay!
Feel free to ping me by slack or email if I'm blocking on this in future.

@jchodera jchodera merged commit ebbe9e0 into conda-forge:main Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants