Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mkdocstrings-python-legacy, mkdocstrings-python, and griffe #18245

Merged
merged 10 commits into from Mar 7, 2022
Merged

add mkdocstrings-python-legacy, mkdocstrings-python, and griffe #18245

merged 10 commits into from Mar 7, 2022

Conversation

bandersen23
Copy link
Contributor

@bandersen23 bandersen23 commented Mar 6, 2022

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mkdocstrings-python-legacy) and found it was in an excellent condition.

@bandersen23 bandersen23 marked this pull request as ready for review March 6, 2022 00:07
@bandersen23 bandersen23 marked this pull request as draft March 6, 2022 00:35
@bandersen23 bandersen23 marked this pull request as ready for review March 6, 2022 16:49
@bandersen23
Copy link
Contributor Author

@conda-forge/help-python - This is ready for review 😄 Thanks!

@bandersen23 bandersen23 changed the title mkdocstrings-python-legacy add mkdocstrings-python-legacy Mar 6, 2022
@hadim
Copy link
Member

hadim commented Mar 6, 2022

LGTM for me (not a conda forge reviewer but FYI).

Do you think mkdocstrings-python and griffe should be packaged as well? Those are optional deps mkdocstrings, but I feel like users might want to have them by default too.

@bandersen23
Copy link
Contributor Author

I'm working on that for a different PR now. Probably submitted later today.

@hadim
Copy link
Member

hadim commented Mar 6, 2022

Thanks for the work @bandersen23 !

@bandersen23 bandersen23 changed the title add mkdocstrings-python-legacy add mkdocstrings-python-legacy, mkdocstrings-python, and griffe Mar 7, 2022
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/griffe, recipes/mkdocstrings-python, recipes/mkdocstrings-python-legacy) and found some lint.

Here's what I've got...

For recipes/griffe:

  • The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'requirements', 'test', 'about', 'extra'].

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/griffe, recipes/mkdocstrings-python, recipes/mkdocstrings-python-legacy) and found it was in an excellent condition.

@bandersen23
Copy link
Contributor Author

@conda-forge/staged-recipes This is ready to review! Thank you so much!

This is for: conda-forge/mkdocstrings-feedstock#19 (comment)

@chrisburr chrisburr merged commit c7cfb18 into conda-forge:main Mar 7, 2022
@hadim
Copy link
Member

hadim commented Mar 8, 2022

@bandersen23
Copy link
Contributor Author

Good catch. @chrisburr thanks for approving! Any idea why this might be? I know there's a lot going on so I wonder if the CI is busy?

@BastianZim
Copy link
Member

You can follow the logs of the CI here: https://github.com/conda-forge/staged-recipes/actions
Seems like some rate-limiting, should resolve itself in a couple of hours.

@bandersen23
Copy link
Contributor Author

Awesome! I didn't know that, thanks for sharing!

@bandersen23
Copy link
Contributor Author

bandersen23 commented Mar 8, 2022

@BastianZim I looked at the logs for these three packages and they keep getting errors on the feedstock creation (I copied the error from one of the three feedstocks, but these three seem to be getting it:

CI Summary for conda-forge/mkdocstrings-python-legacy-feedstock (can take ~30s):
[1264](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1264)
Traceback (most recent call last):
[1265](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1265)
  File "/home/runner/Mambaforge/bin/conda-smithy", line 10, in <module>
[1266](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1266)
    sys.exit(main())
[1267](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1267)
  File "/home/runner/Mambaforge/lib/python3.9/site-packages/conda_smithy/cli.py", line 681, in main
[1268](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1268)
    args.subcommand_func(args)
[1269](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1269)
  File "/home/runner/Mambaforge/lib/python3.9/site-packages/conda_smithy/cli.py", line 296, in __call__
[1270](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1270)
    ci_register.travis_configure(owner, repo)
[1271](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1271)
  File "/home/runner/Mambaforge/lib/python3.9/site-packages/conda_smithy/ci_register.py", line 504, in travis_configure
[1272](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1272)
    response.raise_for_status()
[1273](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1273)
  File "/home/runner/Mambaforge/lib/python3.9/site-packages/requests/models.py", line 960, in raise_for_status
[1274](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1274)
    raise HTTPError(http_error_msg, response=self)
[1275](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1275)
requests.exceptions.HTTPError: 403 Client Error: Forbidden for url: https://api.travis-ci.com/repo/22901922/setting/builds_only_with_travis_yml
[1276](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1276)
Traceback (most recent call last):
[1277](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1277)
  File "/home/runner/work/staged-recipes/staged-recipes/.travis_scripts/create_feedstocks.py", line 283, in <module>
[1278](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1278)
    subprocess.check_call(
[1279](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1279)
  File "/home/runner/Mambaforge/lib/python3.9/subprocess.py", line 373, in check_call
[1280](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1280)
    raise CalledProcessError(retcode, cmd)
[1281](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1281)
subprocess.CalledProcessError: Command '['conda', 'smithy', 'register-ci', '--without-appveyor', '--without-webservice', '--feedstock_directory', '/tmp/tmp9cn24gzc__feedstocks/mkdocstrings-python-legacy-feedstock', '--organization', 'conda-forge']' returned non-zero exit status 1.

@BastianZim
Copy link
Member

Yeah, that happens from time to time, unfortunately. Generally, this resolves itself after some hours, otherwise you can post in the gitter chat and someone from the respective team will have a look.

@bandersen23
Copy link
Contributor Author

Great, I'll check it later tonight and see how it's doing! 👍

@bandersen23
Copy link
Contributor Author

@conda-forge/core - any thoughts on why these three recipe are not getting built? I just checked and noticed they still haven't been built, but they have an empty git repo. Is it a problem that the git repo was already created? They've been merged in for ~24 hours now and I keep seeing the same error on the create feedstocks action. Thank you 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants