Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for PyPy3.8 and PyPy3.9 #191

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update pypy38.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/2747054568, please use this URL for debugging.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mattip
Copy link

mattip commented Jul 31, 2022

Importing scikitlearn is failing to import joblib which is failing to import cloudpickle because PyPy has no _pickle accelerator module. A victim of this issue which seems to be due to cloudpickle depending on undefined pickle behaviour (even on CPython, when using the pure-python pickle module cloudpickle fails). This comment from a scikit-learn contributor suggests there is a fix for this in upstream? I couldn't find it searching issues and PRs in the repo, but maybe my search-foo is too weak.

@mattip
Copy link

mattip commented Jul 31, 2022

The joblib failure is a bit strange since upstream both tests with pypy and vendors cloudpickle.

@mattip
Copy link

mattip commented Aug 25, 2022

@conda-forge-admin please rerender

@thomasjpfan
Copy link
Member

@conda-forge-admin please rerender

@thomasjpfan
Copy link
Member

thomasjpfan commented Sep 12, 2022

This PR waiting for joblib to have a release that includes joblib/joblib#1323

@thomasjpfan
Copy link
Member

@conda-forge-admin please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@thomasjpfan thomasjpfan added the bot-rerun Instruct the bot to retry the PR label Sep 29, 2022
@regro-cf-autotick-bot
Copy link
Contributor Author

Due to the bot-rerun label I'm closing this PR. I will make another one as appropriate. This was generated by https://github.com/regro/autotick-bot/actions/runs/3158511295

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-pypy38-0-1_h0f65cb branch September 30, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot-rerun Instruct the bot to retry the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants