Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patch fixing GenericAlias on 3.9 #79

Merged
merged 3 commits into from
Apr 7, 2022

Conversation

mattip
Copy link
Contributor

@mattip mattip commented Apr 5, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Fixes incompatibility with types.GenericAlias, discovered in the numpy-feedstock conda-forge/numpy-feedstock#263 and fixed in https://foss.heptapod.net/pypy/pypy/-/issues/3720

Also refactored an import of inspect in _ctypes to avoid importing too many other modules. This came up in a name clash where gobject-introspection has its own ast module that clashes with the stdlib one.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mattip
Copy link
Contributor Author

mattip commented Apr 5, 2022

@conda-forge-admin, please rerender

@mattip
Copy link
Contributor Author

mattip commented Apr 5, 2022

CI is passing. Could someone review?

@lithomas1
Copy link
Contributor

Unrelated, but can you also delete the pre-7.3.9 patches? I forgot to do that in my other PR. Thanks.

@mattip
Copy link
Contributor Author

mattip commented Apr 5, 2022

delete the pre-7.3.9 patches

Done

@mattip
Copy link
Contributor Author

mattip commented Apr 5, 2022

Once this gets merged, I can rebuild the aarch64 and ppc packages on the gcc buildfarm. @isuruf once I do that how do I upload them?

@isuruf
Copy link
Member

isuruf commented Apr 7, 2022

You can upload to your own channel and I can copy it. Can you keep the logs of building the package?
Btw, I can give you access to our machines. Otherwise you'll have to make sure to use docker or start with a clean CentOS 7 VM.

@mattip
Copy link
Contributor Author

mattip commented Apr 7, 2022

Access would be nice. I sent you a mail with my details

@mattip
Copy link
Contributor Author

mattip commented Apr 9, 2022

@isuruf I have uploaded the aarch64 and ppc64le packages to https://anaconda.org/mattip and attached the logs.txt files.
logs_aarch64.txt
logs_ppc64le.txt

The commands I used (slightly modified your recommendations) are at https://gist.github.com/mattip/1cb3c04fe1c285f62dfb4884cc1c5f22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants