Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to protobuf v22.0. #180

Closed
wants to merge 2 commits into from
Closed

Conversation

bdice
Copy link

@bdice bdice commented Feb 28, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Updating to a new version: https://github.com/protocolbuffers/protobuf/releases/tag/v22.0

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bdice
Copy link
Author

bdice commented Feb 28, 2023

@conda-forge-admin, please rerender

@xylar
Copy link
Contributor

xylar commented Feb 28, 2023

Not really any point in doing this here until conda-forge/libprotobuf-feedstock#145 goes in.

@xylar
Copy link
Contributor

xylar commented Feb 28, 2023

But you're welcome to get a head start.

@bdice
Copy link
Author

bdice commented Feb 28, 2023

Ah, thanks @xylar. I wasn't familiar with how this was packaged. Let me know if I can help with anything.

@xylar
Copy link
Contributor

xylar commented Feb 28, 2023

It looked like @h-vetinari had a pretty hard go at getting rc2 to work here conda-forge/libprotobuf-feedstock#144, seemingly without quite succeeding. I imagine it'll be a little time before we can update.

@h-vetinari
Copy link
Member

See conda-forge/conda-forge-pinning-feedstock#4075. I'm trying to do abseil first, then grpc, then protobuf. Protobuf will be trickier than usual due to an API/ABI break (new major number). The issues in the PR are solvable, but currently lower priority than shepherding the other migrations. Abseil is currently intertwined with re2 and segfaulting on arrow, where I'll likely need some upstream help. Untangling all of this will take some time, I'm afraid.

@bdice
Copy link
Author

bdice commented May 22, 2023

Closing in favor of #186. Thanks @h-vetinari for the effort here.

@bdice bdice closed this May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants