Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test #69 #70

Closed
wants to merge 4 commits into from
Closed

test #69 #70

wants to merge 4 commits into from

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Dec 10, 2019

Testing to see if we can reproduce the failure from #69 in the CIs.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ocefpaf
Copy link
Member Author

ocefpaf commented Dec 10, 2019

@gillins do you know what may be wrong in the libtiff recipe that could cause this failure?

@gillins
Copy link

gillins commented Dec 11, 2019

Hmmm... Do you know anything about tempfile.tif?

tempfile.tif: Cannot read TIFF header.

@gillins
Copy link

gillins commented Dec 11, 2019

I think this is a bit suspect (something gone wrong after the /M) but can't see anything obviously wrong with setup.py:

/DNDEBUG /M-DHAVE_LIBTIFF -DPILLOW_VERSION="\"6.2.1\""

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ocefpaf
Copy link
Member Author

ocefpaf commented Feb 26, 2020

I think this is a bit suspect (something gone wrong after the /M) but can't see anything obviously wrong with setup.py:

/DNDEBUG /M-DHAVE_LIBTIFF -DPILLOW_VERSION="\"6.2.1\""

I rebased this against latest master to check if the new version fixed that but it seems that the issue remains :-(

@gillins
Copy link

gillins commented Feb 29, 2020

@ocefpaf seems to be compiling OK now, just the tests failing.

@ocefpaf
Copy link
Member Author

ocefpaf commented Mar 2, 2020

@ocefpaf seems to be compiling OK now, just the tests failing.

I probably looked at the wrong logs. The test error is:

tempfile.tif: Cannot read TIFF header.
Traceback (most recent call last):
  File "D:\bld\pillow_1582740975412\test_tmp\run_test.py", line 8, in <module>
    im.load()
  File "D:\bld\pillow_1582740975412\_test_env\lib\site-packages\PIL\TiffImagePlugin.py", line 1070, in load
    return self._load_libtiff()
  File "D:\bld\pillow_1582740975412\_test_env\lib\site-packages\PIL\TiffImagePlugin.py", line 1182, in _load_libtiff
    raise OSError(err)
OSError: -2

I'll make a few tests with libtiff to see if I can fix that. Thanks @gillins!

@pkgw
Copy link
Contributor

pkgw commented Feb 8, 2021

The relevant issue has been solved down in libtiff.

@pkgw pkgw closed this Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants