Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pangeo-dask metapackage version(s) #6

Merged
merged 2 commits into from Apr 3, 2020
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 3, 2020

One or more new Dask package versions have been detected.

Updated meta.yamls to use:
- dask =2.13.0
- distributed =2.13.0
- dask-kubernetes =0.10.1
- dask-gateway =0.6.1

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@scottyhq
Copy link
Contributor

scottyhq commented Apr 3, 2020

Excellent! Should we add effectively the same workflow here https://github.com/conda-forge/pangeo-notebook-feedstock and watch the bots cascade PRs all the way to https://github.com/pangeo-data/pangeo-stacks-dev ?

@TomAugspurger
Copy link
Contributor

FYI, Dask will likely have another release today. Is that going to mess up the calver version? Or is it not a problem if we only have the cron stuff run once per day?

@scottyhq
Copy link
Contributor

scottyhq commented Apr 3, 2020

If I understand this workflow step https://github.com/conda-forge/pangeo-dask-feedstock/blob/master/.github/workflows/watch-conda-forge.yml#L90 If new packages appear while this PR is open the PR will be updated with a force-commit.

I can think of two approaches:

  1. Run this cronjob once per day. If there are package changes a unique PR gets created from a upgrade-dask-versions-CALVER branch. If no new versions exist, no PR is created. Since we can only create one pangeo-dask=CALVER release per day, automatically close PRs after 24 hours. Disadvantage being we might get a lot of PR emails!

  2. Keep a single PR open and keep committing version bumps until merged. Would be nice to update the first comment message in the PR for this, but seems tricky currently (see Combine create and update in a single configuration? peter-evans/create-or-update-comment#9). Easier to just add a new message to the PR for each change - https://github.com/pangeo-data/pangeo-stacks-dev/blob/a33c9b65eeb1fbbe298a27fcba32b856aa39edaf/.github/workflows/WatchCondaForge.yml#L46

@jhamman
Copy link
Member

jhamman commented Apr 3, 2020

The "right" way to do this is probably to keep the calver the same but bump the build number in the recipe. Honestly, I'm not particularly concerned at this point with this edge case. It is unlikely to occur often and we can manually edit the recipe when it does. At some point, it may be nice to automate this step but I don't think it is worth our time right now.

@scottyhq
Copy link
Contributor

scottyhq commented Apr 3, 2020

@jhamman - speaking of I think we need to bump the build number on this PR - it looks like the workflow in your fork already released to conda-forge!

conda search -c conda-forge pangeo-dask

Loading channels: done
# Name                       Version           Build  Channel
pangeo-dask                    0.0.2               0  conda-forge
pangeo-dask                    0.0.2               2  conda-forge
pangeo-dask               2020.03.27               0  conda-forge
pangeo-dask               2020.03.30               0  conda-forge
pangeo-dask               2020.04.03               0  conda-forge

@jhamman
Copy link
Member

jhamman commented Apr 3, 2020

Yikes! I'm not sure how that happened but okay, I've bumped the build number.

@jhamman
Copy link
Member

jhamman commented Apr 3, 2020

I'm going to merge now so we can be ready for the upcoming dask version bump.

@jhamman jhamman merged commit 9ba0868 into master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants