Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove py dependency from recipe #27

Merged
merged 2 commits into from Dec 1, 2022

Conversation

jcollado
Copy link
Contributor

@jcollado jcollado commented Nov 30, 2022

py is no longer needed by nox code according to:
https://github.com/wntrblm/nox/blob/main/CHANGELOG.md wntrblm/nox#647

Not installing py in the first place is a good way avoid this vulnerability:
pytest-dev/py#287

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

py is no longer neeed by nox code according to:
https://github.com/wntrblm/nox/blob/main/CHANGELOG.md
wntrblm/nox#647

Not installing py in the first place is a good way avoid this
vulnerability:
pytest-dev/py#287
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jcollado
Copy link
Contributor Author

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/nox-feedstock/actions/runs/3587409720.

@jcollado jcollado mentioned this pull request Nov 30, 2022
3 tasks
@jcollado
Copy link
Contributor Author

For the builds that failed, I see the following error:

zstd.ZstdError: zstd compress error: Allocation error : not enough memory

I don't know if there's a way to change the instance size to fix the problem.

@kynan kynan closed this Dec 1, 2022
@kynan kynan reopened this Dec 1, 2022
@kynan kynan merged commit 3af52ec into conda-forge:main Dec 1, 2022
@kynan
Copy link
Contributor

kynan commented Dec 1, 2022

Turning it off an on again seems to have done the trick @jcollado 😀

@jcollado jcollado deleted the remove-py-dependency branch December 1, 2022 23:34
@jcollado
Copy link
Contributor Author

jcollado commented Dec 1, 2022

Turning it off an on again seems to have done the trick @jcollado grinning

Great, thanks @kynan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants