5.1.4, noarch #51
5.1.4, noarch #51
Conversation
…nda-forge-pinning 2020.01.27
minrk
requested review from
blink1073,
bollwyvl,
Carreau,
jakirkham,
ocefpaf and
pelson
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Looks like it's hitting this: pytest-dev/pytest#6517 |
|
Might be simplest to pin pytest at 5.3.3 for this release. |
|
|
||
| build: | ||
| number: 0 | ||
| skip: True # [py<34] | ||
| noarch: python |
There was a problem hiding this comment.
Can we in fact go noarch when the kernel.json still has a platform-specific path? I've wondered if we couldn't go to file:/// refs, which are more portable... I may tinker with the bot PR...
| @@ -22,17 +22,17 @@ requirements: | |||
| - ipython >=5.0 | |||
| - jupyter_client | |||
| - pip | |||
| - python | |||
| - python >=3.4 | |||
There was a problem hiding this comment.
Given it's no longer tested on 3.4, shouldn't this be 3.5?
There was a problem hiding this comment.
Surely it should match whatever setup.py says. i.e. what it can be installed with, rather than what it should be installed with.
| @@ -22,17 +22,17 @@ requirements: | |||
| - ipython >=5.0 | |||
| - jupyter_client | |||
There was a problem hiding this comment.
Do we need to force a pin here from the recent client releases w/r/t py38/win issues?
| - tornado >=4.2 | ||
| - traitlets >=4.1 | ||
|
|
||
| test: | ||
| requires: | ||
| - curio # [unix] | ||
| - curio | ||
| - nose | ||
| - numpy | ||
| - pytest |
There was a problem hiding this comment.
Yeah, pinning this to pytest !=5.3.4 does get the noarch to build locally... haven't tried on windows.
|
So I think we can try pushing this out as |
|
Over on #52, i was able to get the tests to pass (with one flake) by applying the asyncio patch before programmatically running the tests. That seems pretty heavy, as "works with py38 on windows" is a pretty big feature, and i haven't dug into the failures not covered to know whether this will meet every downstreams needs without a patch. However, I assume the path that is covered by the patch, namely folks starting kernels under |
|
I have still not tried building this noarch on linux and installing on windows to see if the |
|
Confirmed: the |
|
However, once i changed the |
bwomp, nope. Forgot about that file. Merged #52 instead. Thanks for keeping it correct! |
|
Hooray!
…On Tue, Jan 28, 2020, 06:22 Min RK ***@***.***> wrote:
Closed #51 <#51>.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#51?email_source=notifications&email_token=AAALCRF5YCWDKBOPST3GEXLRAAIQ7A5CNFSM4KL7FN7KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWHXS7UA#event-2985242576>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALCRHRJK4JVDTUMGXWYDTRAAIQ7ANCNFSM4KL7FN7A>
.
|
Having dropped Python 2 support, we no longer have conditional dependencies and can be noarch.