Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for protobuf423 #136

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update protobuf423.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/5065418050, please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member

@coryan, there's no rush, but for curiosity: you mentioned that the next google-cloud-cpp version will support the newest protobuf/grpc. Is there already a timeline for when that's supposed to be released?

Also, now that we have a newer protobuf, do we still need the skips from this patch?

# Several libraries do not compile under Conda. Depending on the platform
# and compiler, they need a newer version of Protobuf. That is, they
# compile with older versions of Protobuf on some combinations of platform,
# combpiler, and C++ standard library. For more information, see:
# https://github.com/googleapis/google-cloud-cpp/issues/8125
# https://github.com/googleapis/google-cloud-cpp/issues/8145
# https://github.com/googleapis/google-cloud-cpp/issues/8785
- patches/0001-disable-libraries.patch

@coryan
Copy link
Contributor

coryan commented May 24, 2023

@coryan, there's no rush, but for curiosity: you mentioned that the next google-cloud-cpp version will support the newest protobuf/grpc. Is there already a timeline for when that's supposed to be released?

We typically create a new release on the first business day of each month. So I would expect 2023-06-01 or 2023-06-02.

Also, now that we have a newer protobuf, do we still need the skips from this patch?

I think we can remove those. We confirmed that googleapis/google-cloud-cpp#8785 no longer applies with Protobuf 23.1. I will be working on googleapis/google-cloud-cpp#8125 and googleapis/google-cloud-cpp#8145 this week. Don't worry if the bugs are not "fixed" by the next release: one of our builds uses an older version of Protobuf, so I may wait until that build is updated to close them.

# Several libraries do not compile under Conda. Depending on the platform
# and compiler, they need a newer version of Protobuf. That is, they
# compile with older versions of Protobuf on some combinations of platform,
# combpiler, and C++ standard library. For more information, see:
# https://github.com/googleapis/google-cloud-cpp/issues/8125
# https://github.com/googleapis/google-cloud-cpp/issues/8145
# https://github.com/googleapis/google-cloud-cpp/issues/8785
- patches/0001-disable-libraries.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants