Pinning bokeh to version 1 in versions of jupyterlab-nvdashboard that didn't explicitly set this #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jupyterlab-nvdashboard that didn't explicitly set this.
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Sorry for letting this slip, but is this still relevant 2 years later |
|
No problem, @hmaarrfk let me resolve the conflicts and fix up this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patching some old 0.1.11 builds of jupyterlab-nvdashboard to pin the Bokeh version below 2.
I discussed this issue with @jakirkham back on issue jupyterlab-nvdashboard issue 66 several months ago.
I noticed it still occasionally causes problems when installing jupyterlab-nvdashboard into some existing conda environments.
Note this is my first attempt at a patch - I don't know what I'm doing and haven't tested this (I don't know how) - I just copy-pasted existing code and looked at other PRs. Hoping to get some tips on the PR so I can confirm it is in a good state before being truly ready to merge. Apologies for my ignorance of the process.