Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require menuinst>=2 in conda-build 3.28.0 and 3.28.1 #619

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jaimergp
Copy link
Member

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

@jaimergp jaimergp requested a review from a team as a code owner December 14, 2023 09:01
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@xhochy
Copy link
Member

xhochy commented Dec 15, 2023

@jaimergp Is this ready? I'm missing a diff here as an indicator, otherwise would be fine to merge.

@jaimergp
Copy link
Member Author

Not sure why 3.28.0 is not patched:

2023-12-14T09:06:52.5325387Z 
2023-12-14T09:10:18.7552525Z patching repodata:   0%|          | 0/9 [00:00<?, ?it/s]
2023-12-14T09:10:18.7555516Z patching repodata:  11%|█         | 1/9 [03:26<27:29, 206.22s/it]
2023-12-14T09:10:18.7556174Z ================================================================================
2023-12-14T09:10:18.7556724Z ================================================================================
2023-12-14T09:10:18.7557286Z noarch
2023-12-14T09:10:18.7557590Z 
2023-12-14T09:10:19.8584723Z 
2023-12-14T09:10:19.8593920Z patching repodata:  22%|██▏       | 2/9 [03:27<09:58, 85.56s/it] 
2023-12-14T09:10:19.8600346Z ================================================================================
2023-12-14T09:10:19.8605396Z ================================================================================
2023-12-14T09:10:19.8610752Z linux-armv7l
2023-12-14T09:10:19.8615330Z 
2023-12-14T09:12:57.4645187Z 
2023-12-14T09:12:57.4647409Z patching repodata:  33%|███▎      | 3/9 [06:04<11:50, 118.46s/it]
2023-12-14T09:12:57.4648149Z ================================================================================
2023-12-14T09:12:57.4648681Z ================================================================================
2023-12-14T09:12:57.4649197Z linux-aarch64
2023-12-14T09:12:57.4649850Z linux-aarch64::conda-build-3.28.1-py39h387a52e_0.conda
2023-12-14T09:12:57.4650507Z linux-aarch64::conda-build-3.28.1-py311hec3470c_0.conda
2023-12-14T09:12:57.4651477Z linux-aarch64::conda-build-3.28.1-py310h4c7bcd0_0.conda
2023-12-14T09:12:57.4652081Z linux-aarch64::conda-build-3.28.1-py39h4420490_0.conda
2023-12-14T09:12:57.4652655Z linux-aarch64::conda-build-3.28.1-py38he3eb160_0.conda
2023-12-14T09:12:57.4653123Z -    "menuinst",
2023-12-14T09:12:57.4653552Z +    "menuinst >=2.0.1",
2023-12-14T09:12:57.4653838Z 
2023-12-14T09:15:20.8419942Z 
2023-12-14T09:15:20.8421126Z 
2023-12-14T09:15:20.8429455Z patching repodata:  44%|████▍     | 4/9 [08:28<10:41, 128.30s/it]================================================================================
2023-12-14T09:15:20.8435778Z ================================================================================
2023-12-14T09:15:20.8442191Z linux-ppc64le
2023-12-14T09:15:20.8448385Z linux-ppc64le::conda-build-3.28.1-py310h194a6c8_0.conda
2023-12-14T09:15:20.8454794Z linux-ppc64le::conda-build-3.28.1-py39h8d2a46d_0.conda
2023-12-14T09:15:20.8477854Z linux-ppc64le::conda-build-3.28.1-py39h0b1cf3c_0.conda
2023-12-14T09:15:20.8479099Z linux-ppc64le::conda-build-3.28.1-py311h1af927a_0.conda
2023-12-14T09:15:20.8480422Z linux-ppc64le::conda-build-3.28.1-py38h8328f6c_0.conda
2023-12-14T09:15:20.8481098Z -    "menuinst",
2023-12-14T09:15:20.8572531Z +    "menuinst >=2.0.1",
2023-12-14T09:15:20.8574299Z 
2023-12-14T09:15:48.3427885Z 
2023-12-14T09:15:48.3466729Z patching repodata:  56%|█████▌    | 5/9 [08:55<06:07, 91.95s/it] 
2023-12-14T09:15:48.3467425Z ================================================================================
2023-12-14T09:15:48.3468234Z ================================================================================
2023-12-14T09:15:48.3468793Z linux-64
2023-12-14T09:15:48.3469411Z linux-64::conda-build-3.28.1-py39hf3d152e_0.conda
2023-12-14T09:15:48.3470096Z linux-64::conda-build-3.28.1-py38h578d9bd_0.conda
2023-12-14T09:15:48.3470728Z linux-64::conda-build-3.28.1-py310hff52083_0.conda
2023-12-14T09:15:48.3471341Z linux-64::conda-build-3.28.1-py311h38be061_0.conda
2023-12-14T09:15:48.3471977Z linux-64::conda-build-3.28.1-py39h4162558_0.conda
2023-12-14T09:15:48.3472532Z -    "menuinst",
2023-12-14T09:15:48.3474582Z +    "menuinst >=2.0.1",
2023-12-14T09:15:48.3475169Z 
2023-12-14T09:17:51.7199121Z 
2023-12-14T09:17:51.7202636Z ================================================================================
2023-12-14T09:17:51.7204538Z ================================================================================
2023-12-14T09:17:51.7205323Z osx-arm64
2023-12-14T09:17:51.7205874Z osx-arm64::conda-build-3.28.1-py311h267d04e_0.conda
2023-12-14T09:17:51.7206445Z osx-arm64::conda-build-3.28.1-py310hbe9552e_0.conda
2023-12-14T09:17:51.7206984Z osx-arm64::conda-build-3.28.1-py39h2804cbe_0.conda
2023-12-14T09:17:51.7207682Z osx-arm64::conda-build-3.28.1-py38h10201cd_0.conda
2023-12-14T09:17:51.7208106Z -    "menuinst",
2023-12-14T09:17:51.7208432Z +    "menuinst >=2.0.1",
2023-12-14T09:17:51.7208691Z 
2023-12-14T09:17:51.7208905Z 
2023-12-14T09:18:22.2371822Z patching repodata:  67%|██████▋   | 6/9 [10:59<05:07, 102.64s/it]
2023-12-14T09:18:22.2373413Z 
2023-12-14T09:18:22.2395005Z patching repodata:  78%|███████▊  | 7/9 [11:29<02:38, 79.06s/it] ================================================================================
2023-12-14T09:18:22.2395840Z ================================================================================
2023-12-14T09:18:22.2396130Z win-32
2023-12-14T09:18:22.2396294Z 
2023-12-14T09:23:29.7677580Z 
2023-12-14T09:23:29.7681149Z ================================================================================
2023-12-14T09:23:29.7682284Z ================================================================================
2023-12-14T09:23:29.7682851Z osx-64
2023-12-14T09:23:29.7683451Z osx-64::conda-build-3.28.1-py39h6e9494a_0.conda
2023-12-14T09:23:29.7683937Z osx-64::conda-build-3.28.1-py311h6eed73b_0.conda
2023-12-14T09:23:29.7684482Z osx-64::conda-build-3.28.1-py39h43b90dd_0.conda
2023-12-14T09:23:29.7685148Z osx-64::conda-build-3.28.1-py310h2ec42d9_0.conda
2023-12-14T09:23:29.7685934Z osx-64::conda-build-3.28.1-py38h50d1736_0.conda
2023-12-14T09:23:29.7686321Z -    "menuinst",
2023-12-14T09:23:29.7686617Z +    "menuinst >=2.0.1",
2023-12-14T09:23:29.7686862Z 
2023-12-14T09:23:29.7687023Z 
2023-12-14T09:24:04.6151650Z patching repodata:  89%|████████▉ | 8/9 [16:37<02:31, 151.79s/it]
2023-12-14T09:24:04.6187356Z 
2023-12-14T09:24:04.6188344Z patching repodata: 100%|██████████| 9/9 [17:12<00:00, 115.24s/it]================================================================================
2023-12-14T09:24:04.6188941Z ================================================================================
2023-12-14T09:24:04.6189312Z win-64
2023-12-14T09:24:04.6189979Z win-64::conda-build-3.28.1-py311h1ea47a8_0.conda
2023-12-14T09:24:04.6190565Z win-64::conda-build-3.28.1-py38haa244fe_0.conda
2023-12-14T09:24:04.6191052Z win-64::conda-build-3.28.1-py39h0d475fb_0.conda
2023-12-14T09:24:04.6191526Z win-64::conda-build-3.28.1-py39hcbf5309_0.conda
2023-12-14T09:24:04.6191973Z win-64::conda-build-3.28.1-py310h5588dad_0.conda
2023-12-14T09:24:04.6192408Z -    "menuinst",
2023-12-14T09:24:04.6193415Z +    "menuinst >=2.0.1",
2023-12-14T09:24:04.6193795Z 
2023-12-14T09:24:04.6194003Z 
2023-12-14T09:24:04.6194461Z patching repodata: 100%|██████████| 9/9 [17:12<00:00, 114.68s/it]
2023-12-14T09:24:06.5814796Z 
2023-12-14T09:24:06.5818404Z Resource usage statistics from building conda-forge-repodata-patches:
2023-12-14T09:24:06.5818693Z    Process count: 5
2023-12-14T09:24:06.5818960Z    CPU time: Sys=0:00:09.5, User=0:32:08.0
2023-12-14T09:24:06.5819175Z    Memory: 3.6G
2023-12-14T09:24:06.5819381Z    Disk usage: 1.6K
2023-12-14T09:24:06.5819598Z    Time elapsed: 0:17:27.1

@jaimergp
Copy link
Member Author

Same, 3.28.0 is not patched. Is it because it's marked as broken? Anyway, ready for review and merge @xhochy

@jaimergp jaimergp changed the title Menuinst2 conda build Require menuinst>=2 in conda-build 3.28.0 and 3.28.1 Dec 17, 2023
@jaimergp
Copy link
Member Author

Ah, 3.28.1 is marked as broken now too, so maybe we don't need this after all. 3.28.2 should pin this adequately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants