Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patch (enforce numpy<=1.19) for sigpy_0.1.25_1 build #602

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gschramm
Copy link

@gschramm gschramm commented Nov 29, 2023

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

@gschramm gschramm requested a review from a team as a code owner November 29, 2023 10:22
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@gschramm
Copy link
Author

@zklaus to be checked

@gschramm gschramm marked this pull request as draft November 29, 2023 10:23
@gschramm
Copy link
Author

my first patch PR. The aim is to correct the numpy dependency on 0.1.25_1 (has to be numpy <= 1.19 because np.float was deprecated in 1.20)

@gschramm gschramm changed the title add patch (enforce numpy<=1.19) for sigpu_0.1.25_1 build add patch (enforce numpy<=1.19) for sigpy_0.1.25_1 build Nov 29, 2023
@gschramm
Copy link
Author

output of python show_diff.py

================================================================================
================================================================================
linux-armv7l
================================================================================
================================================================================
win-32
================================================================================
================================================================================
osx-arm64
osx-arm64::clang-17.0.6-hc359061_0.conda
+  "constrains": [
+    "clang-tools 17.0.6.*",
+    "llvm 17.0.6.*",
+    "llvm-tools 17.0.6.*",
+    "llvmdev 17.0.6.*"
+  ],
osx-arm64::clang-tools-17.0.6-default_ha3f7cdb_0.conda
-    "clangdev 17.0.6"
+    "clang 17.0.6.*",
+    "clangdev 17.0.6",
+    "llvm 17.0.6.*",
+    "llvm-tools 17.0.6.*",
+    "llvmdev 17.0.6.*"
================================================================================
================================================================================
linux-aarch64
linux-aarch64::clang-17.0.6-h5271726_0.conda
+  "constrains": [
+    "clang-tools 17.0.6.*",
+    "llvm 17.0.6.*",
+    "llvm-tools 17.0.6.*",
+    "llvmdev 17.0.6.*"
+  ],
linux-aarch64::clang-tools-17.0.6-default_h95d19f2_0.conda
-    "clangdev 17.0.6"
+    "clang 17.0.6.*",
+    "clangdev 17.0.6",
+    "llvm 17.0.6.*",
+    "llvm-tools 17.0.6.*",
+    "llvmdev 17.0.6.*"
================================================================================
================================================================================
linux-ppc64le
linux-ppc64le::clang-17.0.6-h381f82a_0.conda
+  "constrains": [
+    "clang-tools 17.0.6.*",
+    "llvm 17.0.6.*",
+    "llvm-tools 17.0.6.*",
+    "llvmdev 17.0.6.*"
+  ],
linux-ppc64le::clang-tools-17.0.6-default_ha79e3c0_0.conda
-    "clangdev 17.0.6"
+    "clang 17.0.6.*",
+    "clangdev 17.0.6",
+    "llvm 17.0.6.*",
+    "llvm-tools 17.0.6.*",
+    "llvmdev 17.0.6.*"
================================================================================
================================================================================
noarch
noarch::sigpy-0.1.25-pyha21a80b_1.conda
-    "numpy",
+    "numpy <=1.19",
================================================================================
================================================================================
win-64
================================================================================
================================================================================
osx-64
osx-64::clang-17.0.6-h897cf5c_0.conda
+  "constrains": [
+    "clang-tools 17.0.6.*",
+    "llvm 17.0.6.*",
+    "llvm-tools 17.0.6.*",
+    "llvmdev 17.0.6.*"
+  ],
osx-64::clang-tools-17.0.6-default_h7e3957e_0.conda
-    "clangdev 17.0.6"
+    "clang 17.0.6.*",
+    "clangdev 17.0.6",
+    "llvm 17.0.6.*",
+    "llvm-tools 17.0.6.*",
+    "llvmdev 17.0.6.*"
================================================================================
================================================================================
linux-64
linux-64::clang-17.0.6-ha0738ec_0.conda
+  "constrains": [
+    "clang-tools 17.0.6.*",
+    "llvm 17.0.6.*",
+    "llvm-tools 17.0.6.*",
+    "llvmdev 17.0.6.*"
+  ],
linux-64::clang-tools-17.0.6-default_h1cdf331_0.conda
-    "clangdev 17.0.6"
+    "clang 17.0.6.*",
+    "clangdev 17.0.6",
+    "llvm 17.0.6.*",
+    "llvm-tools 17.0.6.*",
+    "llvmdev 17.0.6.*"

@beckermr
Copy link
Member

The llvm patches are normal to see. Lgtm.

@gschramm
Copy link
Author

Can someone explain what "Modifications won't affect packages built in the future" means?

@beckermr
Copy link
Member

It means that this patch won't match to new packages that get built. Your patch is fine since it matches to a specific artifact.

@gschramm gschramm marked this pull request as ready for review November 29, 2023 20:19
@zklaus
Copy link
Contributor

zklaus commented Apr 18, 2024

Somehow we left this PR in limbo. Should we still merge, @beckermr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants