Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrize the pydantic validation for better error message #601

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hmaarrfk
Copy link
Contributor

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

@hmaarrfk hmaarrfk requested a review from a team as a code owner November 28, 2023 18:32
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jaimergp
Copy link
Member

Is this slower by any chance? We should check. I remember seeing drastic performance improvements in constructor when we switched from pytest parametrization to an inner for loop. That had like thousands of cases, not lower hundreds like here, but just in case, I thought I'd ask.

Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Nov 28, 2023

Is this slower by any chance

this in my mind is the most worthwhile "test" that we can run and communicate to contributors.

I will check the logs and see if there is any appreciable difference:

This PR the parametrized tests take:
Start time: 2023-11-28T19:37:34.5421079Z
End time: 2023-11-28T19:37:34.5653805Z

under 1 second on 19 mins... i feel like we are ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants