Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OSX SDK pinning for qt-main on arm64 #225

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

andfoy
Copy link

@andfoy andfoy commented Feb 8, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@andfoy andfoy requested a review from a team as a code owner February 8, 2022 17:19
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

recipe/gen_patch_json.py Outdated Show resolved Hide resolved
recipe/gen_patch_json.py Outdated Show resolved Hide resolved
@andfoy
Copy link
Author

andfoy commented Feb 9, 2022

@isuruf, is this one ready?

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Mar 9, 2023

Sorry for letting this go. I guess people forget to check up on all PRs. is this still relevant today?

@andfoy
Copy link
Author

andfoy commented Mar 9, 2023

This was before updating Qt to 5.15.14, so I think this can be marked as not needed anymore?

Copy link

@varlackc varlackc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be some conflicts in the current branch.
As soon as the conflicts are resolve, we should be ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants