Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finish combined abseil/grpc/protobuf migration #4955

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

@h-vetinari h-vetinari requested a review from a team as a code owner September 26, 2023 06:09
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

h-vetinari commented Sep 26, 2023

Biggest issue with this is actually if we're ready to bump the MACOSX_DEPLOYMENT_TARGET globally (it was suggested to include this in the migrator in the context of conda-forge/conda-forge.github.io#1844 resp. #4814)

updated the PR after discussion in that issue.

@h-vetinari
Copy link
Member Author

FYI I plan to merge this and move forward with #4962 on the weekend. Please let me know if anyone has some concerns with that.

@h-vetinari h-vetinari changed the title finish abseil/grpc/protobuf migration finish combined abseil/grpc/protobuf migration Oct 8, 2023
@h-vetinari h-vetinari merged commit db1000d into conda-forge:main Oct 8, 2023
4 checks passed
@h-vetinari h-vetinari deleted the proto branch October 8, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant