Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 1.22.4 #38

Merged
merged 4 commits into from Sep 21, 2021
Merged

Upgrade to 1.22.4 #38

merged 4 commits into from Sep 21, 2021

Conversation

jcollado
Copy link
Contributor

@jcollado jcollado commented May 6, 2021

Upgrade to chalice 1.22.4.

Latest version uses a more recent version of pip that fixes this security issue:
pypa/pip#9827

This is reported by safety as follows:

+==============================================================================+
| pip | 20.0.2 | <21.1 | 40291 |
+==============================================================================+
| Pip 21.1 stops splitting on unicode separators in git references, which |
| could be maliciously used to install a different revision on the repository. |
| See: pypa/pip#9827. Additionally, pip 21.1 |
| updates urllib3 to 1.26.4 to fix CVE-2021-28363.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@jcollado jcollado requested a review from sodre as a code owner May 6, 2021 08:06
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [29]

@jcollado
Copy link
Contributor Author

jcollado commented May 6, 2021

@conda-forge-admin please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jcollado
Copy link
Contributor Author

jcollado commented May 6, 2021

More information on the reason I decided to remove the pip check command for now:
conda-forge/inquirer-feedstock#5

@jcollado
Copy link
Contributor Author

@sodre Please let me know if there's anything I can do to speed up the PR review process, thanks.

@jcollado
Copy link
Contributor Author

@sodre Any update on this?

@sodre
Copy link
Member

sodre commented Sep 21, 2021

@jcollado, this looks good. Would you like to become a maintainer of this package?

@sodre sodre merged commit 906aa3a into conda-forge:master Sep 21, 2021
@jcollado jcollado deleted the upgrade-to-1.22.4 branch October 1, 2021 14:13
@jcollado
Copy link
Contributor Author

jcollado commented Oct 1, 2021

Thanks for getting back to me @sodre. I don't really have experience as package maintainer, but you can add me if you wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants