allow chardet 4 since it has been released #55
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
| @@ -28,7 +28,7 @@ requirements: | |||
| - python | |||
| - async-timeout >=3.0,<4.0 | |||
| - attrs >=17.3.0 | |||
| - chardet >=2.0,<4.0 | |||
| - chardet >=2.0,<5.0 | |||
There was a problem hiding this comment.
This is pinned at <4 in the current release: https://github.com/aio-libs/aiohttp/blob/2f655a59d0daedfa2a794996c4355b576c98ecc8/setup.py#L69
There was a problem hiding this comment.
Yes, I saw that. It is in fact why the tests are failing. They have merged to master a commit back in December that updates to allow chardet 4.0 (aio-libs/aiohttp#5333), but there have been no releases since then. We would like to support environments that include chardet 4. Can we cherry-pick the patch #5333 since it only allows the new chardet (no other related code changes)?
There was a problem hiding this comment.
I added the change in PR5333 to a patch, and now everything passes. Please review. Thanks!
Now that chardet 4 is released, expand the runtime requirement
Checklist
conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)<-- I don't think re-rendering is needed since the latest accepted PR was only a few days ago -->