CI examples #7

memsharded · 2022-03-10T14:09:50Z

No description provided.

memsharded

This is failing, because it needs the changes in conan-io/conan#10744 first

lasote

Fantastic

czoido · 2022-03-10T16:19:11Z

examples/ci/game/ai/src/ai.cpp

+    // ARCHITECTURES
+    #ifdef _M_X64
+    std::cout << "  ai/" << PKG_VERSION << ": _M_X64 defined\n";
+    #endif
+
+    #ifdef _M_IX86
+    std::cout << "  ai/" << PKG_VERSION << ": _M_IX86 defined\n";
+    #endif
+
+    #if __i386__
+    std::cout << "  ai/" << PKG_VERSION << ": __i386__ defined\n";
+    #endif
+
+    #if __x86_64__
+    std::cout << "  ai/" << PKG_VERSION << ": __x86_64__ defined\n";
+    #endif
+
+    // Libstdc++
+    #if defined _GLIBCXX_USE_CXX11_ABI
+    std::cout << "  ai/" << PKG_VERSION << ": _GLIBCXX_USE_CXX11_ABI "<< _GLIBCXX_USE_CXX11_ABI << "\n";
+    #endif
+
+    // COMPILER VERSIONS
+    #if _MSC_VER
+    std::cout << "  ai/" << PKG_VERSION << ": _MSC_VER" << _MSC_VER<< "\n";
+    #endif
+
+    #if _MSVC_LANG
+    std::cout << "  ai/" << PKG_VERSION << ": _MSVC_LANG" << _MSVC_LANG<< "\n";
+    #endif
+
+    #if __cplusplus
+    std::cout << "  ai/" << PKG_VERSION << ": __cplusplus" << __cplusplus<< "\n";
+    #endif
+
+    #if __INTEL_COMPILER
+    std::cout << "  ai/" << PKG_VERSION << ": __INTEL_COMPILER" << __INTEL_COMPILER<< "\n";
+    #endif
+
+    #if __GNUC__
+    std::cout << "  ai/" << PKG_VERSION << ": __GNUC__" << __GNUC__<< "\n";
+    #endif
+
+    #if __GNUC_MINOR__
+    std::cout << "  ai/" << PKG_VERSION << ": __GNUC_MINOR__" << __GNUC_MINOR__<< "\n";
+    #endif
+
+    #if __clang_major__
+    std::cout << "  ai/" << PKG_VERSION << ": __clang_major__" << __clang_major__<< "\n";
+    #endif
+
+    #if __clang_minor__
+    std::cout << "  ai/" << PKG_VERSION << ": __clang_minor__" << __clang_minor__<< "\n";
+    #endif
+
+    #if __apple_build_version__
+    std::cout << "  ai/" << PKG_VERSION << ": __apple_build_version__" << __apple_build_version__<< "\n";
+    #endif
+
+    // SUBSYSTEMS
+
+    #if __MSYS__
+    std::cout << "  ai/" << PKG_VERSION << ": __MSYS__" << __MSYS__<< "\n";
+    #endif
+
+    #if __MINGW32__
+    std::cout << "  ai/" << PKG_VERSION << ": __MINGW32__" << __MINGW32__<< "\n";
+    #endif
+
+    #if __MINGW64__
+    std::cout << "  ai/" << PKG_VERSION << ": __MINGW64__" << __MINGW64__<< "\n";
+    #endif
+
+    #if __CYGWIN__
+    std::cout << "  ai/" << PKG_VERSION << ": __CYGWIN__" << __CYGWIN__<< "\n";
+    #endif


May we remove all this code for the libraries?

Yes, I thought so, didn't do it yet, because it could be useful for users running this example in other platforms. But sure, maybe better to simplify.

czoido · 2022-03-10T16:20:46Z

examples/ci/game/run_example.py

+# Just create a project with a cool dependency graph, and
+# and 2 consuming applications, everything with version ranges
+print("- Part 1: Setup the project initial state -")
+run('conan remove "*" -f')  # Make sure no packages from last run


Can we just remove the libraries that take part in this example? One can run this example locally and accidentally removing all the conan cache

Also a good approach could be to setup a CONAN_HOME to run this, to keep things clean too.
I still need to figure out a few things, like uploading the packages, and the final build->develop package promotion in Artifactory, this would be related, maybe I need to figure out a couple of different CONAN_HOMEs to really mimic a distributed environment.

czoido · 2022-03-10T17:07:07Z

I think the set of operations done in this example is enough to start to understand the basic tools you have in Conan to setup your ci flows. Just some comments if you consider they could be useful:

Could we rename matrix to math and physx that is an actual sdk to physics? Also I had sometimes difficulties figuring the connections between the different libraries... for me it was not so natural that gameserver dependend on physx, maybe if it was on network or something like that...
Could we add for each step a more detailed explanation and also what the person that executes those steps should have learned while doing it? Also an ASCII graph of the dependencies and applications would be nice.
Before we merge I think we should put the example in a more meaningful location or at least less generic than examples/ci/game

memsharded · 2022-03-10T17:18:58Z

Could we rename matrix to math and physx that is an actual sdk to physics? Also I had sometimes difficulties figuring the connections between the different libraries... for me it was not so natural that gameserver dependend on physx, maybe if it was on network or something like that...

I started using math and it was very problematic because it was colliding with the system math.h. Then I could start renaming the files and libraries inside the math package for something different, but it didn't look great. I am fine with renaming "physics", or using any other package name. The thing is that "network" depending on "matrix" didn't have much sense either, and I wanted to have that diamond. So suggestion welcome

Could we add for each step a more detailed explanation and also what the person that executes those steps should have learned while doing it? Also an ASCII graph of the dependencies and applications would be nice.

Yes, the documentation, slides, graph, etc will follow. I wanted to make sure the proposed CI flow makes sense first. I don't think the docs in the run_example.py should be more exhaustive, but in the main Conan docs.

Before we merge I think we should put the example in a more meaningful location or at least less generic than examples/ci/game

Agree, to discuss where.

czoido · 2022-03-10T17:49:38Z

Could we rename matrix to math and physx that is an actual sdk to physics? Also I had sometimes difficulties figuring the connections between the different libraries... for me it was not so natural that gameserver dependend on physx, maybe if it was on network or something like that...

I started using math and it was very problematic because it was colliding with the system math.h. Then I could start renaming the files and libraries inside the math package for something different, but it didn't look great. I am fine with renaming "physics", or using any other package name. The thing is that "network" depending on "matrix" didn't have much sense either, and I wanted to have that diamond. So suggestion welcome

Oh, I see... Let's keep it as is for the moment and take a moment to do some brainstorming before merging and see if we come up with something very intuitive.

Could we add for each step a more detailed explanation and also what the person that executes those steps should have learned while doing it? Also an ASCII graph of the dependencies and applications would be nice.

Yes, the documentation, slides, graph, etc will follow. I wanted to make sure the proposed CI flow makes sense first. I don't think the docs in the run_example.py should be more exhaustive, but in the main Conan docs.

Yes, I meant to make it easier to review this kind of PR, just some basics of what you are trying to teach for each step would be very helpful when reviewing at least.

czoido · 2022-03-11T07:19:36Z

What about a dumb/simplegame that does not depend on the AI, just have some graphics? Like this:

Maybe it's a bit more intuitive?

franramirez688 · 2022-03-11T08:13:04Z

Great job @memsharded
About the discussion of the names, what about this diagram? Perhaps, it's a bit more intuitive:

czoido · 2022-03-11T08:14:34Z

Great job @memsharded About the discussion of the names, what about this diagram? Perhaps, it's a bit more intuitive:

I like the simpleplot idea, but I would keep mathlib that is a typical one for this kind of applications

franramirez688 · 2022-03-11T10:07:05Z

I like the simpleplot idea, but I would keep mathlib that is a typical one for this kind of applications

As discussed before:

memsharded added 7 commits March 8, 2022 18:35

start

165ca8e

started ci example

34dd559

wip

33a83e6

wip

22033aa

wip

3bb9d00

full build

84c8fa3

working

cdc953c

memsharded commented Mar 10, 2022

View reviewed changes

lasote approved these changes Mar 10, 2022

View reviewed changes

memsharded requested review from czoido and franramirez688 March 10, 2022 16:13

czoido reviewed Mar 10, 2022

View reviewed changes

memsharded added 3 commits March 11, 2022 14:55

renaming

ed0cd85

wip

f3b9e52

wip

bc8f521

franramirez688 approved these changes Mar 14, 2022

View reviewed changes

memsharded mentioned this pull request Apr 27, 2022

New 2.0 lockfiles conan-io/tribe#34

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI examples #7

CI examples #7

memsharded commented Mar 10, 2022

memsharded left a comment

lasote left a comment

czoido Mar 10, 2022

memsharded Mar 10, 2022

czoido Mar 10, 2022

memsharded Mar 10, 2022

czoido commented Mar 10, 2022

memsharded commented Mar 10, 2022 •

edited

czoido commented Mar 10, 2022

czoido commented Mar 11, 2022

franramirez688 commented Mar 11, 2022

czoido commented Mar 11, 2022

franramirez688 commented Mar 11, 2022

CI examples #7

Are you sure you want to change the base?

CI examples #7

Conversation

memsharded commented Mar 10, 2022

memsharded left a comment

Choose a reason for hiding this comment

lasote left a comment

Choose a reason for hiding this comment

czoido Mar 10, 2022

Choose a reason for hiding this comment

memsharded Mar 10, 2022

Choose a reason for hiding this comment

czoido Mar 10, 2022

Choose a reason for hiding this comment

memsharded Mar 10, 2022

Choose a reason for hiding this comment

czoido commented Mar 10, 2022

memsharded commented Mar 10, 2022 • edited

czoido commented Mar 10, 2022

czoido commented Mar 11, 2022

franramirez688 commented Mar 11, 2022

czoido commented Mar 11, 2022

franramirez688 commented Mar 11, 2022

memsharded commented Mar 10, 2022 •

edited