Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add methods order for conan create #3682

Merged
merged 6 commits into from May 8, 2024

Conversation

ErniGH
Copy link
Contributor

@ErniGH ErniGH commented Apr 16, 2024

No description provided.

@ErniGH ErniGH requested a review from czoido April 16, 2024 13:51
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally outdated, this is Conan 1 only

reference/commands/create.rst Outdated Show resolved Hide resolved
reference/commands/create.rst Outdated Show resolved Hide resolved
reference/commands/create.rst Outdated Show resolved Hide resolved
@ErniGH
Copy link
Contributor Author

ErniGH commented Apr 17, 2024

I thought it would be the same as in conan1, I did it again with the conan2 functions

reference/commands/create.rst Outdated Show resolved Hide resolved
reference/commands/create.rst Outdated Show resolved Hide resolved
reference/commands/create.rst Show resolved Hide resolved
reference/commands/create.rst Show resolved Hide resolved
Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better :)

reference/commands/create.rst Outdated Show resolved Hide resolved
reference/commands/create.rst Outdated Show resolved Hide resolved
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better now

ErniGH and others added 2 commits April 19, 2024 11:21
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
@RubenRBS RubenRBS added this to the 2.3.0 milestone May 4, 2024
@czoido czoido changed the base branch from release/2.2 to release/2.3 May 7, 2024 05:25
@czoido czoido modified the milestones: 2.3.0, 2.4.0 May 8, 2024
@czoido czoido merged commit 79382d4 into conan-io:release/2.3 May 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants