Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

settings.yml doc: msvc is autodetected as of conan 1.40.0 #2360

Merged
merged 2 commits into from Jan 17, 2022
Merged

settings.yml doc: msvc is autodetected as of conan 1.40.0 #2360

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae8dec6
msvc is autodetected as of conan 1.40.0
jmarrec Jan 17, 2022
ee46c4d
clarify that autodetect only happens in MSVC 2022
jmarrec Jan 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion reference/config_files/settings.yml.rst
View file
Open in desktop
Expand Up @@ -173,7 +173,7 @@ The new ``msvc`` compiler is a new, **experimental** one, that is intended to de
- At the moment it implements a ``compatible_packages`` fallback to Visual Studio compiled packages, that is, previous existing binaries
compiled with ``settings.compiler="Visual Studio"`` can be used for the ``msvc`` compiler if no binaries exist for it yet.
This behavior can be opted-out with ``core.package_id:msvc_visual_incompatible`` :ref:`global_conf` configuration.
- It is not detected by the profile auto-detect, it needs to explicitly be defined in profiles.
- Starting in conan 1.40.0, ``msvc`` is detected by the profile auto-detect. Before 1.40.0, it needs to be explicitly defined in profiles.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's all there is here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it only happens for VS 2022, isn't it?

 # Visual Studio 2022 onwards, detect as a new compiler "msvc"
    if compiler == "Visual Studio":
        version = Version(version)
        if version == "17":
            compiler = "msvc"
            version = "193"

Maybe worth clarifying?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point yes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


When using the ``msvc`` compiler, the Visual Studio toolset version (the actual ``vcvars`` activation and ``MSBuild`` location) will be
defined by the default provide of that compiler version:
Expand Down