Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated conan.cmake URL to latest version #2265

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jlschrag
Copy link

Version 0.14 of conan.cmake added support for Visual Studio 2019. Updated URL to latest to avoid confusion for VS2019 users.

Version 0.14 of conan.cmake added support for Visual Studio 2019.  Updated URL to latest to avoid confusion for VS2019 users.
@CLAassistant
Copy link

CLAassistant commented Oct 17, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@czoido
Copy link
Contributor

czoido commented Oct 18, 2021

Hi @jlschrag,
Thanks for the contribution, this is a good opportunity to update the rest of the content to align with the recommendations for v0.16.1 of cmake-conan. I will make some further changes on top of this.
I'm converting this to draft until I can add those changes.

@czoido czoido marked this pull request as draft October 18, 2021 13:20
@jlschrag
Copy link
Author

jlschrag commented Dec 2, 2021

Version 0.17.0 of conan-cmake is now out, which add support for VS2022. To avoid this issue again, these documentation references should probably be changed to that version.

Also, a related PR: conan-io/cmake-conan#374. It may be desirable to add the hash check & perhaps some of the other logic seen there to the documentation as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants