Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Xcode 13 #9642

Closed
wants to merge 1 commit into from
Closed

Add support for Xcode 13 #9642

wants to merge 1 commit into from

Conversation

janosvitok
Copy link
Contributor

@janosvitok janosvitok commented Sep 21, 2021

Changelog: Bugfix: Add support for Xcode 13/Apple clang 13.0
Docs: omit

Closes #9641

@CLAassistant
Copy link

CLAassistant commented Sep 21, 2021

CLA assistant check
All committers have signed the CLA.

@memsharded memsharded added this to the 1.41 milestone Sep 21, 2021
@czoido czoido changed the base branch from develop to release/1.40 September 21, 2021 15:09
@czoido czoido changed the base branch from release/1.40 to develop September 21, 2021 15:09
@czoido
Copy link
Contributor

czoido commented Sep 21, 2021

Hi @janosvitok,
I'm opening a new PR: #9643 that includes you as a contributor as well, we are in a little rush because we want to release a 1.40.2 minor with these changes ASAP and we need to change the branches.
Thanks a lot for the contribution. I'm closing this one in favor of: #9643

@czoido czoido closed this Sep 21, 2021
@janosvitok
Copy link
Contributor Author

@czoido, I don't mind how you do it, as long as conan supports Xcode out of box :)

Cheers!

@janosvitok janosvitok deleted the support-for-xcode-13 branch September 21, 2021 17:17
@H-G-Hristov
Copy link

How is this supposed to work. Upgrading conan I mean.

I did pip3 install conan --upgrade

I got the latest conan but when I tried to build. I still got:

-- Conan executing: /usr/local/bin/conan install . -s build_type=RelWithDebInfo -s compiler=apple-clang -s compiler.version=13.0 -s compiler.libcxx=libc++ -s compiler.cppstd=14 -s arch=arm64 -s arch_build=arm64 -s os.version=10.12 -g=cmake --build=missing
ERROR: Invalid setting '13.0' is not a valid 'settings.compiler.version' value.
Possible values are ['5.0', '5.1', '6.0', '6.1', '7.0', '7.3', '8.0', '8.1', '9.0', '9.1', '10.0', '11.0', '12.0']
Read "http://docs.conan.io/en/latest/faq/troubleshooting.html#error-invalid-setting"

So I still had to manually add: "13.0" to ~/.conan/settings.yml as before:

apple-clang: &apple_clang
    version: ["5.0", "5.1", "6.0", "6.1", "7.0", "7.3", "8.0", "8.1", "9.0", "9.1", "10.0", "11.0", "12.0", "13.0"]

@H-G-Hristov H-G-Hristov mentioned this pull request Oct 7, 2021
@memsharded
Copy link
Member

If you had previously modified settings.yml, the Conan migration will not overwrite your existing, modified settings.yml to avoid destroying your modifications. Try removing the settings.yml from the cache, run Conan again (any conan install command) and it will regenerate it with 13.0 in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Support for Xcode 13
5 participants