Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update conan new modern templates #9516

Merged

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Sep 1, 2021

Changelog: Feature: Update conan new modern templates --template=cmake_lib and --template=cmake_exe.
Docs: conan-io/docs#2211

@memsharded memsharded added this to the 1.40 milestone Sep 1, 2021
@memsharded memsharded marked this pull request as ready for review September 1, 2021 13:51
return files


conanfile_exe = """from conans import ConanFile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nonrelated question, are we moving/copying the ConanFile to conan namespace at some point?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we are.
I didn't want to do it yet, because I am thinking of using the move to clean some potentially breaking things, and the opt-in would be the new import.

Copy link
Contributor

@lasote lasote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@memsharded memsharded merged commit 313552e into conan-io:develop Sep 1, 2021
@memsharded memsharded deleted the feature/update_new_templates branch September 1, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants