Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel build files have an extra ] if there are no depenedencies #9480

Merged
merged 3 commits into from Aug 27, 2021
Merged

Bazel build files have an extra ] if there are no depenedencies #9480

merged 3 commits into from Aug 27, 2021

Conversation

ianda
Copy link
Contributor

@ianda ianda commented Aug 26, 2021

Changelog: Bugfix: Bazel build files have an extra ] if there are no dependencies.
Docs: omit

  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • [skipped] Refer to the issue that supports this Pull Request.
  • [skipped] I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@CLAassistant
Copy link

CLAassistant commented Aug 26, 2021

CLA assistant check
All committers have signed the CLA.

@memsharded memsharded added this to the 1.40 milestone Aug 26, 2021
@memsharded
Copy link
Member

Thanks for submitting the fix @ianda

A couple of things:

  • It would be great if you could try to add a unittest that failed because of this bug, and is fixed by this change
  • Could you please sign the CLA?

@ianda
Copy link
Contributor Author

ianda commented Aug 26, 2021

* It would be great if you could try to add a unittest that failed because of this bug, and is fixed by this change

This is not the coolest test but testing that something is not there is often not so cool. The best would be something that parses the file, but that seems to be overpowered to me. Are you ok with the implemented test?

* Could you please sign the CLA?

✔️

@memsharded
Copy link
Member

CI is broken, but seems unrelated to your changes: https://ci.conan.io/blue/organizations/jenkins/ConanTestSuite/detail/PR-9480/4/pipeline

Don't worry about it, we will have a look.

@tapia tapia merged commit 4713ebd into conan-io:develop Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants