Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add missing LIBRARY and FOUND vars in cmake find_package() generator #9457

Closed

Conversation

igxactly
Copy link

@igxactly igxactly commented Aug 20, 2021

Changelog: Fix: Add missing vars in cmake find_package() generator: <PACKAGE>_LIBRARY_DIRS, <PACKAGE>_<COMPONENT>_LIBRARY, <PACKAGE>_<COMPONENT>_FOUND
Docs: missing

Fix #9444

  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.
    • I could not find where to put changelog. It seems like it is for maintainers.

@CLAassistant
Copy link

CLAassistant commented Aug 20, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These generators are considered "legacy", and this kind of change should go first to CMakeDeps, and only in some cases we would consider backporting them to other generators.

@igxactly igxactly closed this Aug 20, 2021
@memsharded
Copy link
Member

Hi @igxactly

In case you would consider submitting these changes for CMakeDeps, please note that there are ongoing changes to add explicit support for "find" modules instead of Config files. At the moment CMakeDeps only implement CMake xxx-config.cmake files, but support for find modules is being drafted in #9455. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] find_package: missing or wrongly named variables
3 participants