Add warning when downloading recipes from bintray #9416

danimtb · 2021-08-12T11:15:06Z

Changelog: omit
Docs: omit

Refer to the issue that supports this Pull Request: continuation of Remove conan-center default remote #9401
If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
I've read the Contributing guide.
I've followed the PEP8 style guides for Python code.
I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

^{Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.}

Here you can check the output of an install command:

Configuration:
[settings]
arch=x86_64
arch_build=x86_64
build_type=Release
compiler=Visual Studio
compiler.runtime=MD
compiler.version=16
os=Windows
os_build=Windows
[options]
[build_requires]
[env]

zlib/1.2.8@conan/stable: Retrieving from server 'conan-center' 
zlib/1.2.8@conan/stable: Trying with 'conan-center'...
zlib/1.2.8@conan/stable: WARN: Remote https://conan.bintray.com is deprecated and will be shut down soon.
zlib/1.2.8@conan/stable: WARN: Please use the new 'conancenter' default remote.
zlib/1.2.8@conan/stable: WARN: Add it to your remotes with: conan remote add -i 0 conancenter https://center.conan.io
Downloading conanmanifest.txt
Downloading conanfile.py
Downloading conan_export.tgz
zlib/1.2.8@conan/stable: Downloaded recipe revision 0
Installing package: zlib/1.2.8@conan/stable
Requirements
    zlib/1.2.8@conan/stable from 'conan-center' - Downloaded
Packages
    zlib/1.2.8@conan/stable:3fb49604f9c2f729b85ba3115852006824e72cab - Download

Installing (downloading, building) binaries...
zlib/1.2.8@conan/stable: Retrieving package 3fb49604f9c2f729b85ba3115852006824e72cab from remote 'conan-center' 
Downloading conanmanifest.txt
Downloading conaninfo.txt
Downloading conan_package.tgz
zlib/1.2.8@conan/stable: Package installed 3fb49604f9c2f729b85ba3115852006824e72cab
zlib/1.2.8@conan/stable: Downloaded package revision 0
Aggregating env generators

danimtb · 2021-08-12T11:18:00Z

conans/test/integration/command/install/install_test.py

+    Warning is only displayed when downloading a recipe from the remote
+    """
+    client = TestClient()
+    client.run("remote add conan-center https://conan.bintray.com")


I tried to avoid using the real bintray remote with a test server using the same URL. However, this lead to modifications to the TestServer class and others in the requester...

Anyway, I think it could be useful to have a test that tracks the availability of the remote so we can drop the message once it is no longer available 🤷‍♂️

Then, in my opinion, I think we should use a "fake" Bintray URL and check the output:

client = TestClient() fake_bintray_url = "https://myfakebintray.com" with patch.object(proxy, "BINTRAY_DEPRECATED_URL", return_value=fake_bintray_url): client.run("remote add conan-center %s" % fake_bintray_url) # .....

What do you think @danimtb?

EDIT: perhaps that client.run() can be outside of the patch

franramirez688 · 2021-08-12T11:33:43Z

conans/client/graph/proxy.py

@@ -113,6 +113,11 @@ def _download_recipe(self, layout, ref, output, remotes, remote, recorder):
        def _retrieve_from_remote(the_remote):
            output.info("Trying with '%s'..." % the_remote.name)
            # If incomplete, resolve the latest in server
+            if "https://conan.bintray.com" in the_remote.url:


I think we should declare that URL as a global variable in this module like:

BINTRAY_DEPRECATED_URL = "https://conan.bintray.com" # ..... if the_remote.url.startswith(BINTRAY_DEPRECATED_URL): # whatever

Then, it should be easier to use it in any test.

jgsogo

Two picky comments

jgsogo · 2021-08-13T06:57:58Z

conans/client/graph/proxy.py

+                output.warn("Please use the new 'conancenter' default remote "
+                           "(https://center.conan.io).")


For these messages, I really find it useful to provide a copy/paste solution to users:

Suggested change

output.warn("Please use the new 'conancenter' default remote "

"(https://center.conan.io).")

output.warn("Please use the new 'conancenter' default remote. Add it to your remotes with "

"'conan remote add --insert 0 conancenter https://center.conan.io'.")

jgsogo · 2021-08-13T07:00:02Z

conans/client/graph/proxy.py

@@ -113,6 +113,11 @@ def _download_recipe(self, layout, ref, output, remotes, remote, recorder):
        def _retrieve_from_remote(the_remote):
            output.info("Trying with '%s'..." % the_remote.name)
            # If incomplete, resolve the latest in server
+            if "https://conan.bintray.com" in the_remote.url:


When using Bintray, if you clicked the set me up button it didn't show you the https://conan.bintray.com/... URL, but https://bintray.com/conan.... (I cannot remember exactly the path)... and many people had that one configured. Do you remember? Do we want to check also for that URL?

Yes, I'd say to check fur bintray.com, that should be good enough for both cases, isn't it?

the URL https://bintray.com/conan.... will be useless as it is not working (only conan.bintray.com is still operational), so checking for it doesn't make sense as it won't work from the beginning and would never get this warning message

This is a very good reason indeed 😄

memsharded · 2021-08-14T14:05:18Z

conans/client/graph/proxy.py

@@ -113,6 +113,11 @@ def _download_recipe(self, layout, ref, output, remotes, remote, recorder):
        def _retrieve_from_remote(the_remote):
            output.info("Trying with '%s'..." % the_remote.name)
            # If incomplete, resolve the latest in server
+            if "https://conan.bintray.com" in the_remote.url:


Yes, I'd say to check fur bintray.com, that should be good enough for both cases, isn't it?

conans/client/graph/proxy.py

danimtb added 3 commits August 12, 2021 13:04

Add warning when downloading recipes from bintray

f917833

fix msg format

6c295cc

change test

091f578

danimtb commented Aug 12, 2021

View reviewed changes

danimtb requested a review from jgsogo August 12, 2021 11:18

danimtb assigned lasote Aug 12, 2021

danimtb added this to the 1.40 milestone Aug 12, 2021

franramirez688 reviewed Aug 12, 2021

View reviewed changes

jgsogo reviewed Aug 13, 2021

View reviewed changes

memsharded approved these changes Aug 14, 2021

View reviewed changes

Use mocked remote

b85a5f8

danimtb requested review from franramirez688 and jgsogo August 18, 2021 09:41

jgsogo approved these changes Aug 18, 2021

View reviewed changes

tapia reviewed Aug 19, 2021

View reviewed changes

conans/client/graph/proxy.py Show resolved Hide resolved

Update conans/client/graph/proxy.py

a780ffa

memsharded unassigned lasote Aug 23, 2021

memsharded merged commit f16ff88 into conan-io:develop Aug 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add warning when downloading recipes from bintray #9416

Add warning when downloading recipes from bintray #9416

danimtb commented Aug 12, 2021 •

edited

danimtb Aug 12, 2021

franramirez688 Aug 12, 2021 •

edited

franramirez688 Aug 12, 2021 •

edited

jgsogo left a comment

jgsogo Aug 13, 2021

jgsogo Aug 13, 2021 •

edited

memsharded Aug 14, 2021

danimtb Aug 18, 2021

jgsogo Aug 18, 2021

memsharded Aug 14, 2021

		output.warn("Please use the new 'conancenter' default remote "
		"(https://center.conan.io).")

Add warning when downloading recipes from bintray #9416

Add warning when downloading recipes from bintray #9416

Conversation

danimtb commented Aug 12, 2021 • edited

danimtb Aug 12, 2021

Choose a reason for hiding this comment

franramirez688 Aug 12, 2021 • edited

Choose a reason for hiding this comment

franramirez688 Aug 12, 2021 • edited

Choose a reason for hiding this comment

jgsogo left a comment

Choose a reason for hiding this comment

jgsogo Aug 13, 2021

Choose a reason for hiding this comment

jgsogo Aug 13, 2021 • edited

Choose a reason for hiding this comment

memsharded Aug 14, 2021

Choose a reason for hiding this comment

danimtb Aug 18, 2021

Choose a reason for hiding this comment

jgsogo Aug 18, 2021

Choose a reason for hiding this comment

memsharded Aug 14, 2021

Choose a reason for hiding this comment

danimtb commented Aug 12, 2021 •

edited

franramirez688 Aug 12, 2021 •

edited

franramirez688 Aug 12, 2021 •

edited

jgsogo Aug 13, 2021 •

edited