Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small refactor to prefer config #8694

Merged
merged 1 commit into from Mar 24, 2021

Conversation

memsharded
Copy link
Member

Changelog: Omit
Docs: Omit

Follow up from #8599:

  • Removed unused import six
  • Reduced a bit the implementation, making more explicit and evident the default: self.find_package_prefer_config = "ON"
  • Make code pep8 compliant, like line lengths
  • Make the test run faster, even if adding 1 more extra check (the default case when conf is not defined). Using a C project, reusing CMake cache, and avoiding compiler checks reduce test time from 14 seconds to just 3 in my machine, covering an extra case. When we are counting +3000 tests, it is important to keep test speed in mind.
  • Remove unittest dependency and use bare assert checks as recommended by pytest. Lets use this new pytest style for new tests when possible.

@memsharded memsharded added this to the 1.35 milestone Mar 23, 2021
@memsharded memsharded requested a review from SSE4 March 23, 2021 23:06
@memsharded memsharded self-assigned this Mar 23, 2021
@memsharded memsharded merged commit 27f6997 into conan-io:develop Mar 24, 2021
@memsharded memsharded deleted the refactor/prefer_config branch March 24, 2021 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants