Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refact] rename 'tools.microsoft:msbuild_verbosity' to 'tools.microsoft.msbuild:verbosity' #8692

Merged
merged 1 commit into from Mar 23, 2021
Merged

[refact] rename 'tools.microsoft:msbuild_verbosity' to 'tools.microsoft.msbuild:verbosity' #8692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion conan/tools/microsoft/msbuild.py
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@


def msbuild_verbosity_cmd_line_arg(conanfile):
verbosity = conanfile.conf["tools.microsoft"].msbuild_verbosity
verbosity = conanfile.conf["tools.microsoft.msbuild"].verbosity
if verbosity:
if verbosity not in ("Quiet", "Minimal", "Normal", "Detailed", "Diagnostic"):
raise ConanException("Unknown msbuild verbosity: {}".format(verbosity))
Expand Down
8 changes: 4 additions & 4 deletions conans/test/integration/configuration/conf/test_conf_package_id.py
View file
Open in desktop
Expand Up @@ -22,13 +22,13 @@ def package_id(self):
def test_package_id(client):
profile1 = textwrap.dedent("""\
[conf]
tools.microsoft:msbuild_verbosity=Quiet""")
tools.microsoft.msbuild:verbosity=Quiet""")
profile2 = textwrap.dedent("""\
[conf]
tools.microsoft:msbuild_verbosity=Minimal""")
tools.microsoft.msbuild:verbosity=Minimal""")
client.save({"profile1": profile1,
"profile2": profile2})
client.run("create . pkg/0.1@ -pr=profile1")
assert "pkg/0.1:b40df771e875672867408f9edf54bec0c2c361a7 - Build" in client.out
assert "pkg/0.1:b85ef030da903577bd87d1c92c0524c9c96212b5 - Build" in client.out
client.run("create . pkg/0.1@ -pr=profile2")
assert "pkg/0.1:017c055fc7833bf6a7836211a26727533237071d - Build" in client.out
assert "pkg/0.1:7d2f1590113db99bcd08a4ebd4c841cc0a2e7020 - Build" in client.out
8 changes: 4 additions & 4 deletions conans/test/integration/configuration/conf/test_conf_profile.py
View file
Open in desktop
Expand Up @@ -52,7 +52,7 @@ def test_cmake_config(client):
compiler.runtime=MD
build_type=Release
[conf]
tools.microsoft:msbuild_verbosity=Minimal
tools.microsoft.msbuild:verbosity=Minimal
""")
client.save({"myprofile": profile})
client.run("create . pkg/0.1@ -pr=myprofile")
Expand All @@ -69,7 +69,7 @@ def test_cmake_config_error(client):
compiler.runtime=MD
build_type=Release
[conf]
tools.microsoft:msbuild_verbosity=non-existing
tools.microsoft.msbuild:verbosity=non-existing
""")
client.save({"myprofile": profile})
client.run("create . pkg/0.1@ -pr=myprofile", assert_error=True)
Expand All @@ -86,7 +86,7 @@ def test_cmake_config_package(client):
compiler.runtime=MD
build_type=Release
[conf]
dep*:tools.microsoft:msbuild_verbosity=Minimal
dep*:tools.microsoft.msbuild:verbosity=Minimal
""")
client.save({"myprofile": profile})
client.run("create . pkg/0.1@ -pr=myprofile")
Expand Down Expand Up @@ -128,7 +128,7 @@ def build(self):
compiler.runtime=MD
build_type=Release
[conf]
tools.microsoft:msbuild_verbosity=Minimal
tools.microsoft.msbuild:verbosity=Minimal
""")
client.save({"myprofile": profile})
client.run("create . pkg/0.1@ -pr=myprofile")
Expand Down