Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cmakedeps files #8655

Merged
merged 8 commits into from Mar 17, 2021
Merged

Conversation

danimtb
Copy link
Member

@danimtb danimtb commented Mar 16, 2021

Changelog: Feature: Move the definition of CMakeDeps variables to its own file
Docs: conan-io/docs#2055

CMakeDeps generator now creates a new mypkg-release-x86-data.cmake file per configuration where the information of the cpp_info is added without getting dynamic values from any other CMake functionality or macro.

This new file(s) is included in the config cmake files as well as the old Target-<build_type>.cmake where the "dynamic" variables are defined (variables that have values assignated after calling macros or cmake functionality)

The implementation is done for recipes defining components and for recipes that do not have components.

As per #8636:

  • Duplicated variables that have been removed: *_INCLUDE_DIR, *_INCLUDES

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@danimtb danimtb self-assigned this Mar 16, 2021
@danimtb danimtb marked this pull request as draft March 16, 2021 10:06
@danimtb danimtb added this to the 1.35 milestone Mar 16, 2021

mark_as_advanced({name}_INCLUDE_DIRS{build_type_suffix}
Copy link
Member Author

@danimtb danimtb Mar 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep this? Is this here to prevent variable modification via CMake GUI?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, mark_as_advanced is just not to pollute CMakeGUI

@danimtb danimtb marked this pull request as ready for review March 16, 2021 12:18
@danimtb danimtb requested a review from memsharded March 16, 2021 12:18
This reverts commit 662785c.
@danimtb
Copy link
Member Author

danimtb commented Mar 17, 2021

Reverted last commit due to conflict with other variables: *_LIBS --> *_LIBRARIES, *_LIB_DIRS --> *_LIBRARY_DIRS

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants